fix: template param in deposit & disbursal templates (#1220)

* fix: param name in deposit & disbursal templates * refactor: rename template param to 'credit_omnibus_account'
GaloyMoney · Jan 13, 2025 · e70a924 · e70a924
1 parent 0c7ac5f
commit e70a924
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/lana/app/src/credit_facility/ledger/mod.rs b/lana/app/src/credit_facility/ledger/mod.rs
@@ -332,7 +332,7 @@ impl CreditLedger {
                 templates::APPROVE_CREDIT_FACILITY_CODE,
                 templates::ApproveCreditFacilityParams {
                     journal_id: self.journal_id,
-                    credit_omnibus_account_id: self.credit_omnibus_account,
+                    credit_omnibus_account: self.credit_omnibus_account,
                     credit_facility_account: credit_facility_account_ids.facility_account_id,
                     facility_disbursed_receivable_account: credit_facility_account_ids
                         .disbursed_receivable_account_id,
@@ -436,7 +436,7 @@ impl CreditLedger {
                 templates::CREDIT_FACILITY_DISBURSAL_CODE,
                 templates::CreditFacilityDisbursalParams {
                     journal_id: self.journal_id,
-                    credit_omnibus_account_id: self.credit_omnibus_account,
+                    credit_omnibus_account: self.credit_omnibus_account,
                     credit_facility_account: credit_facility_account_ids.facility_account_id,
                     facility_disbursed_receivable_account: credit_facility_account_ids
                         .disbursed_receivable_account_id,

diff --git a/lana/app/src/credit_facility/ledger/templates/approve_credit_facility.rs b/lana/app/src/credit_facility/ledger/templates/approve_credit_facility.rs
@@ -13,7 +13,7 @@ pub const APPROVE_CREDIT_FACILITY_CODE: &str = "APPROVE_CREDIT_FACILITY";
 #[derive(Debug)]
 pub struct ApproveCreditFacilityParams {
     pub journal_id: JournalId,
-    pub credit_omnibus_account_id: AccountId,
+    pub credit_omnibus_account: AccountId,
     pub credit_facility_account: AccountId,
     pub facility_disbursed_receivable_account: AccountId,
     pub facility_fee_income_account: AccountId,
@@ -90,7 +90,7 @@ impl From<ApproveCreditFacilityParams> for Params {
     fn from(
         ApproveCreditFacilityParams {
             journal_id,
-            credit_omnibus_account_id,
+            credit_omnibus_account,
             credit_facility_account,
             facility_disbursed_receivable_account,
             facility_fee_income_account,
@@ -104,7 +104,7 @@ impl From<ApproveCreditFacilityParams> for Params {
         let mut params = Self::default();
         params.insert("journal_id", journal_id);
         params.insert("credit_facility_account", credit_facility_account);
-        params.insert("credit_omnibus_account_id", credit_omnibus_account_id);
+        params.insert("credit_omnibus_account", credit_omnibus_account);
         params.insert(
             "facility_disbursed_receivable_account",
             facility_disbursed_receivable_account,
@@ -144,7 +144,7 @@ impl ApproveCreditFacility {
                 .build()
                 .expect("Couldn't build entry"),
             NewTxTemplateEntry::builder()
-                .account_id("params.credit_omnibus_account_id")
+                .account_id("params.credit_omnibus_account")
                 .units("params.facility_amount")
                 .currency("params.currency")
                 .entry_type("'APPROVE_CREDIT_FACILITY_CR'")
@@ -153,7 +153,7 @@ impl ApproveCreditFacility {
                 .build()
                 .expect("Couldn't build entry"),
             NewTxTemplateEntry::builder()
-                .account_id("params.credit_omnibus_account_id")
+                .account_id("params.credit_omnibus_account")
                 .units("params.structuring_fee_amount")
                 .currency("params.currency")
                 .entry_type("'APPROVE_CREDIT_FACILITY_DISBURSEMENT_DRAWDOWN_DR'")

diff --git a/lana/app/src/credit_facility/ledger/templates/disburse.rs b/lana/app/src/credit_facility/ledger/templates/disburse.rs
@@ -13,7 +13,7 @@ pub const CREDIT_FACILITY_DISBURSAL_CODE: &str = "CREDIT_FACILITY_DISBURSAL";
 #[derive(Debug)]
 pub struct CreditFacilityDisbursalParams {
     pub journal_id: JournalId,
-    pub credit_omnibus_account_id: AccountId,
+    pub credit_omnibus_account: AccountId,
     pub credit_facility_account: AccountId,
     pub facility_disbursed_receivable_account: AccountId,
     pub checking_account: AccountId,
@@ -78,12 +78,12 @@ impl From<CreditFacilityDisbursalParams> for Params {
             checking_account,
             disbursed_amount,
             external_id,
-            credit_omnibus_account_id,
+            credit_omnibus_account,
         }: CreditFacilityDisbursalParams,
     ) -> Self {
         let mut params = Self::default();
         params.insert("journal_id", journal_id);
-        params.insert("credit_omnibus_account_id", credit_omnibus_account_id);
+        params.insert("credit_omnibus_account", credit_omnibus_account);
         params.insert("facility_account", credit_facility_account);
         params.insert(
             "facility_disbursed_receivable_account",
@@ -112,7 +112,7 @@ impl CreditFacilityDisbursal {
 
         let entries = vec![
             NewTxTemplateEntry::builder()
-                .account_id("params.credit_omnibus_account_id")
+                .account_id("params.credit_omnibus_account")
                 .units("params.disbursed_amount")
                 .currency("'USD'")
                 .entry_type("'CREDIT_FACILITY_DISBURSAL_DRAWDOWN_DR'")