-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
screens are flickery #1089
Comments
@sandipndev I will fix this dashboard flicker. |
should we maintain a consistent table height regardless of data rows? ex:
This will keep the container height same and might lower the flicker effect on list pages. wdyt @nicolasburtey @designsats ? |
No, table should hug the contents, to be just as high as content needs. We will have a special Empty State graphic for no data to display situation. |
here is an example on how Mercury does it flickering lana versus mercury they either have a page with also, their design page when there is no action/data generally doesn't feel as empty. they also integrate a call to action on those pages when appropriate |
here is the mercury video https://www.loom.com/share/a81d4e37c26041c3965b29c246e05171 |
they don't use a card container for table content so they don't face issues with the card (container with border) size changing from the loading state to the loaded state. this is why I suggested maintaining a consistent table height regardless of the number of data rows so the card size is same. this issue might be less noticeable when the table has enough data, but even then, there's no guarantee that the loading card will match the loaded card. sometimes, data can span multiple rows, which changes the card size and causes the flicker effect. for empty tables, we could implement something similar by displaying a graphic/disc with a "Create" button. any suggestions @designsats? |
@nicolasburtey is this still an issue? |
yes (albeit this feels like a more pressing issue if I had to prioritize #1151) |
|
https://www.loom.com/share/5e6f1fbc8dee49dcb32ce2c73200dd8a
The text was updated successfully, but these errors were encountered: