feat!: embed ledger #1146
Merged
feat!: embed ledger #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vindard
force-pushed
the
feature/embed-ledger
branch
from
af8f79b to
5c2e92f
Compare
This was referenced Dec 13, 2024
Merged
vindard
force-pushed
the
feature/embed-ledger
branch
2 times, most recently
from
52f70fb to
a08cc69
Compare
vindard
force-pushed
the
feature/embed-ledger
branch
3 times, most recently
from
bdd18fd to
43094a4
Compare
|
Storybook preview: Link to Storybook |
vindard
force-pushed
the
feature/embed-ledger
branch
2 times, most recently
from
d43a4c4 to
0b6fefb
Compare
thevaibhav-dixit
force-pushed
the
feature/embed-ledger
branch
from
0b6fefb to
173d536
Compare
vindard
force-pushed
the
feature/embed-ledger
branch
2 times, most recently
from
cd9beba to
6968df1
Compare
* chore(core-deposit): DepositAccount boilerplate * chore(deposit): deposit entity * test: dummy perms wip * test: use DummyPerms in deposit test * test: account -> balance integration * chore(deposit): add DepositLedger * chore: record_deposit template * chore: execute record_deposit template * chore: impl balance usecase * chore: templates for withdraw use case * chore: include deposit in sqlx-prepare * chore: run sqlx prepare * refactor: rename AccountHolderId -> DepositAccountHolderId * chore: withdrawal entity in core * chore: impl withdrawal usecases * chore: sqlx-prepare * fix: add instrumentation to credit_facility.list * chore: clippy * chore: CreditLedger boilerplate * chore: create credit facility accounts * chore: run sqlx-prepare * chore: move get_credit_facility_balance * chore: add / remove collateral templates * chore: fix name --------- Co-authored-by: bodymindarts <justin@galoy.io> Co-authored-by: Vaibhav <thevaibhavdixit@gmail.com>
* wip: withdrawal jobs * chore: genericize deposit approval job * fix: clippy warnings * test: dumnmy objects, actions and events for test * chore: cancel withdrawals * chore: address pr reviews * chore: process error * chore: wire up core deposit in app (#1169) * chore: wire up core deposit in app * refactor: do not expose ledger_account_id from DepositAccount * chore: bump cala * refactor: create_journal in app * refactor: accountHolderId -> customerId * chore: bump cala * test: use deposit_account_id * chore: proper audit entries * fix: execute returns WithdrawalError --------- Co-authored-by: bodymindarts <justin@galoy.io> --------- Co-authored-by: bodymindarts <justin@galoy.io>
* feat: add chart_of_accounts package * feat: add chart of accounts code type * feat: add chart of accounts entity boilerplate * feat: add chart of accounts repo * chore: run sqlx-prepare * feat: add authz chart of account primitives * chore: init chart of accounts package * feat: add chart of account 'find_or_create' * feat: add chart of account create account functions * feat: add 'create account' use cases * feat: add name field to accounts created * feat: add 'find_transaction_account' use-case * fix: AccountIdx Display trait This is to allow formatting properly when converting code to string format. * fix: handle NotFound error and return other errors * refactor: consolidate ChartOfAccountCode enum * test: add account creation integration test * test: add ChartOfAccountCode unit tests * test: and chart of accounts entity unit tests * refactor: move 'code' to crate top level * refactor: move 'ChartOfAccountAccountDetails' to primitives * refactor: change 'create_transaction_account' return type * feat: add chart of accounts ledger * chore: add ledger call from create-account use-case * chore: add 'description' field to accounts * refactor: remove singleton, pass chart id around * chore: add list_charts function
* chore: complete collateral-update * chore: move repay to credit-facility ledger * chore: payment template * fix: rebase issues * chore: execute repayment in embedded ledger * chore: embed complete credit facility * chore: credit facility activation template * chore: interest accural and incurrence templates --------- Co-authored-by: Vaibhav <thevaibhavdixit@gmail.com>
* chore: add account_id param to 'create_transaction_account' * refactor: change charts use-case functions to domain service functions * chore: use chart of accounts to create deposit account * chore: add chart of accounts default id * fix: move normal_balance_type to value object * refactor: change AccountDetails 'code' to 'path' and add 'code' as string * fix: use globally unique ledger codes from chart of accounts This is to fix the issue that there can be multiple charts with same codes and codes are unique in ledger. * chore: pass deposit audit info to chart_of_account operation * chore: transaction_account_factory boilerplate * feat: add reference to chart of account entity * chore: run sqlx-prepare * feat: add find_by_reference for charts * chore: replace ledger with TransactionAccountFactory * chore: add ledger seed & remove charts config * feat: add reference to chart create accounts for idempotency * chore: find or create account paths in seed * refactor: change param from &str to String * chore: move seed to new accounting module --------- Co-authored-by: bodymindarts <justin@galoy.io>
* refactor: rename accounting to accounting_init * refactor: move create_journal to accounting init * refactor: move seed steps into separate functions
* chore: embed disbursal * chore: handle sub op * chore: remove commented code
* chore: admin panel changes for embed-ledger * fix: make deposits DataLoader use private --------- Co-authored-by: vindard <17693119+vindard@users.noreply.github.com>
* fix: param name in deposit & disbursal templates * refactor: rename template param to 'credit_omnibus_account'
* feat: add embedded customer ledger implementation * refactor: swap in new embedded ledger in customer module * refactor: use new customer account ids in other modules
Chart of accounts query needs to be reimplemented as a projection from entity instead of traversing account sets directly from ledger.
* refactor: add 'ChartOfAccountCreationDetails' type * refactor: abstract create_control_sub_account function * chore: add credit facility seed steps * refactor: move app types to app-primitives modules * chore: use chart of accounts create in initiate * fix: fetch chart from in-progress db op
* refactor: move accounting_init primitives to module * fix: use deposit account as customer checking account * chore: remove unused 'ledger' from Customer module * chore: fix error message
vindard
force-pushed
the
feature/embed-ledger
branch
from
c92e19f to
a6b6b76
Compare
thevaibhav-dixit
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-progress PRs:
TODO:
gql_ledgerdependency from credit facilitiesFollow-up PR
TODOsfrom in chore: integrate chart of accounts into credit facility #1187 in follow-up PRChartOfAccountCodeimplementation (use paths naming instead)