Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove customer object from withdraw and deposit #1179

Conversation

siddhart1o1
Copy link
Member

No description provided.

@siddhart1o1 siddhart1o1 changed the base branch from main to feature/embed-ledger December 23, 2024 08:37
@siddhart1o1 siddhart1o1 changed the title chore: remove customer object from withdraw/deposit chore: remove customer object from withdraw and deposit Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

Storybook preview: Link to Storybook

@vindard vindard force-pushed the feature/embed-ledger branch from bdd18fd to 43094a4 Compare December 23, 2024 12:58
@vindard vindard force-pushed the chore--remove-customer-object-from-withdraw/deposit branch from 91dda3e to 89e8c15 Compare December 23, 2024 12:59
@vindard vindard mentioned this pull request Dec 23, 2024
13 tasks
@vindard vindard marked this pull request as ready for review December 23, 2024 13:29
@vindard vindard merged commit 5fae6d2 into feature/embed-ledger Dec 23, 2024
4 of 7 checks passed
vindard added a commit that referenced this pull request Dec 26, 2024
This reverts commit d4d176a.

This is to be able to bring in changes from main without having to
resolve merge conflicts that are temporary anyway and need to be changed
to properly fix checks.
@vindard
Copy link
Contributor

vindard commented Dec 26, 2024

We ended up removing this change from #1146 since it is still incomplete and there were more conflicting changes needed from main. Removed in force-push from d43a4c4 to 0b6fefb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants