Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: contextual create #1223

Merged
merged 1 commit into from
Jan 7, 2025
Merged

chore: contextual create #1223

merged 1 commit into from
Jan 7, 2025

Conversation

siddhart1o1
Copy link
Member

No description provided.

@siddhart1o1 siddhart1o1 requested a review from sandipndev January 7, 2025 11:19
Copy link

github-actions bot commented Jan 7, 2025

Storybook preview: Link to Storybook

@siddhart1o1 siddhart1o1 force-pushed the chore--Contextual-Create branch 3 times, most recently from 15ae08e to 8d454c3 Compare January 7, 2025 12:41
@siddhart1o1 siddhart1o1 force-pushed the chore--Contextual-Create branch from 8d454c3 to 43e316f Compare January 7, 2025 13:08
@sandipndev
Copy link
Member

I think we need to further discuss if we need customer picker / we want a contextual create, not global iiuc

@siddhart1o1
Copy link
Member Author

siddhart1o1 commented Jan 7, 2025

For now, we can create a new entity from 3 pages (for most entities).

  • dashboard page
  • list page ex. credit facilities list page
  • entity details page

When a user is on the "Credit Facility Details" page, they can still create a new credit facility for different customers, and after thinking about this, I feel this flow might be slightly confusing.

Click on create
image

select a customer and then create a CF
image

Current flow:

  1. User is on the Credit Facility Details page.
  2. They click on the Create button → Select Credit Facility → Choose a Customer → Create a facility for that customer.

I am thinking of one of these solutions

  • Remove the “Create Facility” option from the Facility Details page entirely.
  • Allow facility creation on the Details page to only the same customer the current facility belongs to (skipping the customer selection step).

** This is same for other entities withdraw, user, terms template, customer **

let me know WDYT

@siddhart1o1 siddhart1o1 merged commit f816eeb into main Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants