Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network Tcp utilities #1258

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Add network Tcp utilities #1258

merged 8 commits into from
Jul 31, 2024

Conversation

roby2014
Copy link
Member

@roby2014 roby2014 commented Jun 9, 2024 •
edited
Loading

blocked by #1256

Description

Implemented network TcpStream and TcpListener classes.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@roby2014 roby2014 self-assigned this Jun 9, 2024
@roby2014 roby2014 linked an issue Jun 9, 2024 that may be closed by this pull request
Add TCP socket class #1209
Closed
@roby2014 roby2014 changed the title Add TcpSocket network class Add network TcpSocket class Jun 9, 2024
@github-actions github-actions bot added A-Core B-Network Related to networking code labels Jun 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1258/
on branch gh-pages at 2024-07-28 16:22 UTC

@codecov Codecov
Copy link

codecov bot commented Jun 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.62189% with 49 lines in your changes missing coverage. Please review.

Project coverage is 36.20%. Comparing base (9cb63e7) to head (3fef18b).

Files Patch % Lines
core/src/net/tcp_stream.cpp 66.21% 25 Missing ⚠️
core/src/net/tcp_listener.cpp 76.08% 11 Missing ⚠️
core/src/memory/stream.cpp 44.44% 10 Missing ⚠️
core/src/net/utils.cpp 0.00% 2 Missing ⚠️
core/src/memory/buffer_stream.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
+ Coverage   35.95%   36.20%   +0.25%     
==========================================
  Files         385      391       +6     
  Lines       31124    31322     +198     
==========================================
+ Hits        11191    11341     +150     
- Misses      19933    19981      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roby2014 roby2014 added the S-Blocked Blocked on another issue or PR label Jun 11, 2024
@roby2014 roby2014 force-pushed the 1209-add-tcp-socket-class branch 2 times, most recently from 7689080 to 8188497 Compare July 2, 2024 18:07
github-actions[bot]
github-actions bot requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

core/include/cubos/core/net/tcp_socket.hpp Outdated Show resolved Hide resolved
core/src/net/tcp_socket.cpp Outdated Show resolved Hide resolved
core/include/cubos/core/net/tcp_socket.hpp Outdated Show resolved Hide resolved
core/src/net/tcp_socket.cpp Outdated Show resolved Hide resolved
core/include/cubos/core/net/tcp_socket.hpp Outdated Show resolved Hide resolved
core/src/net/tcp_socket.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_socket.cpp Outdated Show resolved Hide resolved
@roby2014 roby2014 force-pushed the 1209-add-tcp-socket-class branch 2 times, most recently from b6b147e to b42cde8 Compare July 2, 2024 19:43
@roby2014 roby2014 force-pushed the 1209-add-tcp-socket-class branch 2 times, most recently from 1aa7c2d to 43f499a Compare July 15, 2024 18:01
@roby2014 roby2014 changed the title Add network TcpSocket class Add network Tcp utilities Jul 15, 2024
github-actions[bot]
github-actions bot requested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/2)

core/include/cubos/core/net/tcp_stream.hpp Outdated Show resolved Hide resolved
core/src/net/tcp_stream.cpp Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot requested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/2)

core/src/net/tcp_listener.cpp Show resolved Hide resolved
core/src/net/tcp_listener.cpp Outdated Show resolved Hide resolved
core/include/cubos/core/net/tcp_listener.hpp Outdated Show resolved Hide resolved
RiscadoA
RiscadoA reviewed Jul 16, 2024
View reviewed changes
core/include/cubos/core/net/tcp_stream.hpp Outdated Show resolved Hide resolved
core/include/cubos/core/net/tcp_stream.hpp Outdated Show resolved Hide resolved
core/include/cubos/core/net/tcp_stream.hpp Show resolved Hide resolved
core/src/net/tcp_listener.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_listener.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
@roby2014 roby2014 force-pushed the 1209-add-tcp-socket-class branch 9 times, most recently from 8d6ba6b to e3ef924 Compare July 18, 2024 18:41
github-actions[bot]
github-actions bot previously requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

core/tests/net/tcp.cpp Outdated Show resolved Hide resolved
core/tests/net/tcp.cpp Outdated Show resolved Hide resolved
@roby2014 roby2014 marked this pull request as draft July 27, 2024 15:10
RiscadoA
RiscadoA requested changes Jul 28, 2024
View reviewed changes
core/src/net/tcp_stream.cpp Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
@roby2014 roby2014 force-pushed the 1209-add-tcp-socket-class branch 4 times, most recently from 29af0ef to 228f814 Compare July 28, 2024 12:07
@roby2014 roby2014 marked this pull request as ready for review July 28, 2024 12:08
github-actions[bot]
github-actions bot reviewed Jul 28, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

core/src/net/tcp_stream.cpp Outdated Show resolved Hide resolved
RiscadoA
RiscadoA approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the single comment I added, LGTM! Sorry for dragging this on for so long 😔

core/include/cubos/core/net/tcp_stream.hpp Outdated Show resolved Hide resolved
@roby2014 roby2014 force-pushed the 1209-add-tcp-socket-class branch 2 times, most recently from 26f4efd to 4e5b9f1 Compare July 28, 2024 16:22
github-actions[bot]
github-actions bot reviewed Jul 28, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

core/src/net/tcp_stream.cpp Show resolved Hide resolved
@roby2014 roby2014 enabled auto-merge (rebase) July 31, 2024 17:26
@roby2014 roby2014 merged commit b1c946a into main Jul 31, 2024
10 of 11 checks passed
@roby2014 roby2014 deleted the 1209-add-tcp-socket-class branch July 31, 2024 18:50
@RiscadoA RiscadoA mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@EdSwordsmith EdSwordsmith EdSwordsmith approved these changes

@RiscadoA RiscadoA RiscadoA approved these changes

@tomas7770 tomas7770 tomas7770 approved these changes

@Scarface1809 Scarface1809 Scarface1809 approved these changes

Assignees

@roby2014 roby2014

Labels
A-Core B-Network Related to networking code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TCP socket class
5 participants
@roby2014 @EdSwordsmith @RiscadoA @tomas7770 @Scarface1809