Add friction and restitution on penetration constraint solving #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1277 +/- ##
==========================================
- Coverage 36.27% 36.19% -0.08%
==========================================
Files 376 376
Lines 30851 30916 +65
==========================================
Hits 11191 11191
- Misses 19660 19725 +65 ☔ View full report in Codecov by Sentry. |
Closed
fallenatlas
force-pushed
the
1244-add-friction-on-constraint-solving
branch
from
bf5b56a
to
f0628f9
Compare
RiscadoA
approved these changes
Jul 4, 2024
|
@fallenatlas please share your resources for the physics engine to ease reviewing. The math looks right, but i don't know if I'd catch errors without a reference |
DiogoMendonc-a
approved these changes
Jul 4, 2024
luishfonseca
requested changes
Jul 5, 2024
fallenatlas
force-pushed
the
1244-add-friction-on-constraint-solving
branch
from
49215f6
to
62eeb7b
Compare
luishfonseca
approved these changes
Jul 8, 2024
…ion when no tangent component exists and small code refactors
fallenatlas
force-pushed
the
1244-add-friction-on-constraint-solving
branch
from
62eeb7b
to
9fb7ea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: I couldn't find how to apply restitution using accumulated impulses anywhere, which is ridiculous, so the implementation I have is based only on how Erin Catto does it in Box2D v3.0, which he says it's not the most accurate but it seems to work pretty well.
Checklist