fix(ci): do not request changes on clang-tidy-lint.yml #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1290 +/- ##
=======================================
Coverage 36.27% 36.27%
=======================================
Files 376 376
Lines 30851 30851
=======================================
Hits 11191 11191
Misses 19660 19660 ☔ View full report in Codecov by Sentry. |
roby2014
approved these changes
Jul 22, 2024
RiscadoA
requested review from
luishfonseca
and removed request for
EdSwordsmith
luishfonseca
approved these changes
Jul 22, 2024
tomas7770
approved these changes
Jul 23, 2024
RiscadoA
force-pushed
the
1288-clang-tidy-lint-unable-to-dismiss-reviews
branch
from
7df35a5
to
5d5fa9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The action fails while trying to dismiss the reviews, might as well disable the request changes feature.
Note that this doesn't mean disabling the comments, the comments are still there.
Checklist
Evaluate impact on the documentation.Ensure test coverage.Write new samples.Add entry to the changelog's unreleased section.