-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Binary Serializer and Deserializer #1307
Add Binary Serializer and Deserializer #1307
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
==========================================
+ Coverage 35.89% 36.18% +0.28%
==========================================
Files 399 402 +3
Lines 31920 32096 +176
==========================================
+ Hits 11459 11613 +154
- Misses 20461 20483 +22 ☔ View full report in Codecov by Sentry. |
9f8bf5d
to
5b69b2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
5b69b2a
to
3d5e4bb
Compare
Description
Adds both the
BinarySerializer
andBinaryDeserializer
classes, which will be useful for communication between the editor and the game - saves time and memory in comparison with the existing JSON classes.Checklist
Write new samples.I don't think this is relevant here, same interface has other serializers