Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Binary Serializer and Deserializer #1307

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Sep 10, 2024

Description

Adds both the BinarySerializer and BinaryDeserializer classes, which will be useful for communication between the editor and the game - saves time and memory in comparison with the existing JSON classes.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples. I don't think this is relevant here, same interface has other serializers
  • Add entry to the changelog's unreleased section.

@RiscadoA RiscadoA added this to the 0.4 milestone Sep 10, 2024
@RiscadoA RiscadoA self-assigned this Sep 10, 2024
@RiscadoA RiscadoA requested a review from a team as a code owner September 10, 2024 15:03
@RiscadoA RiscadoA linked an issue Sep 10, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Sep 10, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1307/
on branch gh-pages at 2024-09-21 14:44 UTC

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

core/src/data/des/binary.cpp Show resolved Hide resolved
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 75.58140% with 42 lines in your changes missing coverage. Please review.

Project coverage is 36.18%. Comparing base (aedebae) to head (3d5e4bb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/src/data/des/binary.cpp 71.60% 23 Missing ⚠️
core/src/data/ser/binary.cpp 69.84% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
+ Coverage   35.89%   36.18%   +0.28%     
==========================================
  Files         399      402       +3     
  Lines       31920    32096     +176     
==========================================
+ Hits        11459    11613     +154     
- Misses      20461    20483      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 1306-add-binaryserializer-and-binarydeserializer branch from 9f8bf5d to 5b69b2a Compare September 10, 2024 17:36
@RiscadoA RiscadoA enabled auto-merge (rebase) September 12, 2024 14:43
Copy link
Contributor

@fallenatlas fallenatlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@tomas7770 tomas7770 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@diogomsmiranda diogomsmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RiscadoA RiscadoA force-pushed the 1306-add-binaryserializer-and-binarydeserializer branch from 5b69b2a to 3d5e4bb Compare September 21, 2024 14:43
@RiscadoA RiscadoA merged commit 3a4258d into main Sep 21, 2024
9 checks passed
@RiscadoA RiscadoA deleted the 1306-add-binaryserializer-and-binarydeserializer branch September 21, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BinarySerializer and BinaryDeserializer
4 participants