Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opening projects through Tesseratos #1329

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

RiscadoA
Copy link
Member

Description

Adds the project plugin, which adds support for the ProjectManager system argument, along with an ImGui window for opening and closing projects + launching them and terminating them.
Also adds an utility class Process to the core to handle multiple processes in a cross-platform way.

I need people with Windows and MacOS to check if this also works in other operating systems

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@RiscadoA RiscadoA added this to the 0.4 milestone Sep 27, 2024
@RiscadoA RiscadoA self-assigned this Sep 27, 2024
@RiscadoA RiscadoA linked an issue Sep 27, 2024 that may be closed by this pull request
@RiscadoA RiscadoA added the S-Blocked Blocked on another issue or PR label Sep 27, 2024
@RiscadoA RiscadoA force-pushed the 1218-allow-opening-projects-through-tesseratos branch from 54524fd to 964a734 Compare September 27, 2024 17:20
@RiscadoA RiscadoA linked an issue Sep 27, 2024 that may be closed by this pull request
@RiscadoA RiscadoA force-pushed the 1218-allow-opening-projects-through-tesseratos branch from 964a734 to e396faa Compare September 29, 2024 14:09
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1329/
on branch gh-pages at 2024-09-29 14:11 UTC

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

core/src/thread/process.cpp Outdated Show resolved Hide resolved
core/src/thread/process.cpp Show resolved Hide resolved
core/src/thread/process.cpp Outdated Show resolved Hide resolved
@RiscadoA RiscadoA force-pushed the 1218-allow-opening-projects-through-tesseratos branch from 96bb2e4 to 383985e Compare September 29, 2024 14:29
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 4.85075% with 255 lines in your changes missing coverage. Please review.

Project coverage is 41.09%. Comparing base (f19856a) to head (383985e).

Files with missing lines Patch % Lines
core/src/thread/process.cpp 0.00% 66 Missing ⚠️
engine/src/tools/play_pause/plugin.cpp 0.00% 24 Missing ⚠️
engine/src/tools/selection/plugin.cpp 0.00% 20 Missing ⚠️
engine/src/tools/world_inspector/plugin.cpp 0.00% 20 Missing ⚠️
engine/src/tools/transform_gizmo/plugin.cpp 0.00% 15 Missing ⚠️
engine/src/assets/bridges/file.cpp 0.00% 14 Missing ⚠️
engine/src/tools/plugin.cpp 0.00% 13 Missing ⚠️
engine/src/tools/toolbox/toolbox.cpp 0.00% 13 Missing ⚠️
engine/src/tools/toolbox/plugin.cpp 0.00% 12 Missing ⚠️
engine/src/tools/ecs_statistics/plugin.cpp 0.00% 11 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
- Coverage   42.49%   41.09%   -1.41%     
==========================================
  Files         409      428      +19     
  Lines       29229    30258    +1029     
==========================================
+ Hits        12421    12434      +13     
- Misses      16808    17824    +1016     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tesseratos B-Tools S-Blocked Blocked on another issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow launching, pausing and restarting the game from the editor Allow opening projects through Tesseratos
1 participant