-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show stacktrace on CUBOS_FAIL #1333
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
- Coverage 37.41% 37.41% -0.01%
==========================================
Files 410 410
Lines 33195 33198 +3
==========================================
+ Hits 12421 12422 +1
- Misses 20774 20776 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stacktraces look good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice to me 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
620da88
to
47f18cc
Compare
Description
Adds yet another dependency to the core lib, cpptrace.
This one is really necessary - turns out implementing this ourselves is a giant hassle, as there a lot of platform and compiler quirks.
In the future it might no longer be necessary, as C++23 comes with a
<stacktrace>
include - not all compilers support it yet.To use this, I simply call our own
abort
function, which first prints the stacktrace usingcpptrace
, and then calls the usualstd::abort
function.The result looks like this:
Checklist