Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial Scene editor #316

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Add initial Scene editor #316

merged 2 commits into from
Sep 18, 2023

Conversation

roby2014
Copy link
Member

@roby2014 roby2014 commented Feb 8, 2023

No description provided.

@roby2014 roby2014 linked an issue Feb 8, 2023 that may be closed by this pull request
Add initial Scene editor #265
Closed
@RiscadoA
Copy link
Member

Hm, some #270 related code came with this PR, is it ready too?

@roby2014
Copy link
Member Author

roby2014 commented Mar 1, 2023

Hm, some #270 related code came with this PR, is it ready too?

Nope, added by mistake xD

@roby2014 roby2014 marked this pull request as ready for review March 1, 2023 16:40
@roby2014 roby2014 added the tools label Mar 1, 2023
@rsubtil
Copy link
Member

rsubtil commented Mar 2, 2023

Just to confirm, is this ready for review? (Still says [WIP] in the title)

@RiscadoA
Copy link
Member

RiscadoA commented Mar 3, 2023

Just to confirm, is this ready for review? (Still says [WIP] in the title)

He told me it was, but I was waiting for him to remove the unrelated code to review the PR.

@roby2014
Copy link
Member Author

roby2014 commented Mar 3, 2023

Should be ok now, there is a TODO that can be implemented after #264 is done.

@rsubtil rsubtil changed the title [WIP] Add scene editor Add scene editor Mar 3, 2023
@RiscadoA RiscadoA added this to the Tools: Editor 1 milestone May 8, 2023
@RiscadoA RiscadoA marked this pull request as draft May 15, 2023 20:35
@RiscadoA RiscadoA changed the title Add scene editor [WIP] Add scene editor May 15, 2023
@RiscadoA RiscadoA changed the title [WIP] Add scene editor Add scene editor May 27, 2023
@DiogoMendonc-a DiogoMendonc-a force-pushed the 265-add-scene-editor branch 2 times, most recently from e8db4ee to 0352298 Compare May 28, 2023 18:17
@codecov
Copy link

codecov bot commented May 28, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (f09ca17) 24.57% compared to head (a5879b8) 24.57%.

❗ Current head a5879b8 differs from pull request most recent head 059cd45. Consider uploading reports for the commit 059cd45 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   24.57%   24.57%           
=======================================
  Files          90       90           
  Lines        7157     7157           
=======================================
  Hits         1759     1759           
  Misses       5398     5398
Files Changed Coverage Δ
core/include/cubos/core/data/serialization_map.hpp 69.23% <ø> (ø)
core/include/cubos/core/ecs/blueprint.hpp 94.73% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA changed the title Add scene editor Add Scene editor Jun 5, 2023
@RiscadoA RiscadoA removed this from the Tools: Editor 1 milestone Aug 27, 2023
@RiscadoA RiscadoA linked an issue Aug 27, 2023 that may be closed by this pull request
Allow editing in Scene editor #358
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-316/
on branch gh-pages at 2023-09-18 09:10 UTC

@RiscadoA RiscadoA mentioned this pull request Aug 30, 2023
Closed
RiscadoA
RiscadoA requested changes Aug 31, 2023
View reviewed changes
core/include/cubos/core/ecs/commands.hpp Outdated Show resolved Hide resolved
core/include/cubos/core/data/serialization_map.hpp Outdated Show resolved Hide resolved
core/include/cubos/core/ecs/blueprint.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/assets/assets.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/tools/scene_editor/plugin.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/assets/example_asset.json Outdated Show resolved Hide resolved
tools/tesseratos/assets/main.cubos Show resolved Hide resolved
tools/tesseratos/assets/example_asset.json Outdated Show resolved Hide resolved
tools/tesseratos/src/main.cpp Outdated Show resolved Hide resolved
@RiscadoA
Copy link
Member

Don't forget to clean up the commit messages

@RiscadoA RiscadoA added S-Blocked Blocked on another issue or PR and removed S-Blocked Blocked on another issue or PR labels Aug 31, 2023
@DiogoMendonc-a DiogoMendonc-a self-assigned this Sep 12, 2023
@DiogoMendonc-a DiogoMendonc-a marked this pull request as ready for review September 14, 2023 08:10
RiscadoA
RiscadoA requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/tools/scene_editor/plugin.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/tools/scene_editor/plugin.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
RiscadoA
RiscadoA requested changes Sep 14, 2023
View reviewed changes
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
@DiogoMendonc-a DiogoMendonc-a force-pushed the 265-add-scene-editor branch 2 times, most recently from a5879b8 to 140ed95 Compare September 14, 2023 13:09
RiscadoA
RiscadoA requested changes Sep 14, 2023
View reviewed changes
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/scene_editor/plugin.cpp Outdated Show resolved Hide resolved
RiscadoA
RiscadoA previously approved these changes Sep 18, 2023
View reviewed changes
@RiscadoA RiscadoA changed the title Add Scene editor Add initial Scene editor Sep 18, 2023
@DiogoMendonc-a DiogoMendonc-a merged commit 82ac899 into main Sep 18, 2023
1 check passed
@DiogoMendonc-a DiogoMendonc-a deleted the 265-add-scene-editor branch September 18, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiogoMendonc-a DiogoMendonc-a DiogoMendonc-a left review comments

@RiscadoA RiscadoA RiscadoA approved these changes

Assignees

@DiogoMendonc-a DiogoMendonc-a

Labels
A-Engine A-Tesseratos B-Scene B-Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow editing in Scene editor Add initial Scene editor
5 participants
@roby2014 @RiscadoA @rsubtil @DiogoMendonc-a @luishfonseca