Cleanup and document engine-sample.input
#580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
=======================================
Coverage 29.71% 29.71%
=======================================
Files 86 86
Lines 6158 6158
=======================================
Hits 1830 1830
Misses 4328 4328 ☔ View full report in Codecov by Sentry. |
luishfonseca
requested changes
Sep 25, 2023
RiscadoA
changed the title
engine-sample.input
RiscadoA
changed the title
engine-sample.inputengine-sample.input
DiogoMendonc-a
force-pushed
the
472-cleanup-and-document-engine-sampleinput
branch
from
5a414b9
to
c97b77e
Compare
luishfonseca
approved these changes
Sep 27, 2023
DiogoMendonc-a
force-pushed
the
472-cleanup-and-document-engine-sampleinput
branch
from
c97b77e
to
01cd6e1
Compare
RiscadoA
requested changes
Sep 27, 2023
There was a problem hiding this comment.
I think you should mention in the docs thar Input is a resource and that the showcase functions you're showing are not systems, and that there's a system passing the input resource there.
Maybe you should show that system or part of it too, just to make it clear where stuff is coming from.
DiogoMendonc-a
force-pushed
the
472-cleanup-and-document-engine-sampleinput
branch
from
01cd6e1
to
6273cf5
Compare
RiscadoA
approved these changes
Sep 28, 2023
DiogoMendonc-a
deleted the
472-cleanup-and-document-engine-sampleinput
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.