Define reflection for glm types #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
+ Coverage 36.29% 36.57% +0.28%
==========================================
Files 88 89 +1
Lines 6318 6357 +39
==========================================
+ Hits 2293 2325 +32
- Misses 4025 4032 +7
☔ View full report in Codecov by Sentry. |
luishfonseca
force-pushed
the
539-define-reflection-for-glm-types
branch
2 times, most recently
from
788bc42
to
b1a5ea9
Compare
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
dismissed stale reviews from themself
No clang-tidy warnings found so I assume my comments were addressed
luishfonseca
force-pushed
the
539-define-reflection-for-glm-types
branch
from
8465b31
to
6af58ef
Compare
luishfonseca
force-pushed
the
539-define-reflection-for-glm-types
branch
3 times, most recently
from
c33a627
to
b01ce1f
Compare
RiscadoA
requested changes
Sep 28, 2023
luishfonseca
force-pushed
the
539-define-reflection-for-glm-types
branch
from
424360c
to
6716ade
Compare
luishfonseca
force-pushed
the
539-define-reflection-for-glm-types
branch
from
6ec40f3
to
3d54b8c
Compare
RiscadoA
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Constructible and Fields traits for all glm types
Checklist