Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI config #271

Closed
jamesgeddes opened this issue Apr 14, 2021 · 6 comments · Fixed by #247
Closed

Update CircleCI config #271

jamesgeddes opened this issue Apr 14, 2021 · 6 comments · Fixed by #247
Assignees
Labels
P1 Issues that are both high impact and urgent pre-go-live Required for MVP

Comments

@jamesgeddes
Copy link
Contributor

CircleCI needs rabbitmq and celery. Update.

@jamesgeddes jamesgeddes added pre-go-live Required for MVP P1 Issues that are both high impact and urgent labels Apr 14, 2021
@jamesgeddes jamesgeddes self-assigned this Apr 14, 2021
@jamesgeddes jamesgeddes mentioned this issue Apr 14, 2021
5 tasks
@jamesgeddes
Copy link
Contributor Author

@jamesgeddes
Copy link
Contributor Author

As I understand it, I think we need to build a custom docker image from the CircleCI base image that then adds in Python and RabbitMQ. Celery should come with requirements.txt and we can run a celery worker as part of the run commands.

@giulio-giunta Does that sound about right?

@giulio-giunta
Copy link
Contributor

giulio-giunta commented Apr 19, 2021 via email

@jamesgeddes
Copy link
Contributor Author

Perhaps it is better to start from the CircleCI base image then just install stuff on it.

@jamesgeddes
Copy link
Contributor Author

@jamesgeddes
Copy link
Contributor Author

@SamWinterhalder SamWinterhalder linked a pull request Apr 20, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Issues that are both high impact and urgent pre-go-live Required for MVP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants