Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored deploy jobs in cicd pipeline #698

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Restored deploy jobs in cicd pipeline #698

merged 5 commits into from
Nov 29, 2023

Conversation

giulio-giunta
Copy link
Contributor

Description

Currently, the deploy jobs in the cicd pipeline are commented out.

Related Issue

"resolves #693"

Motivation and Context

The deploy jobs were commented out because there had been an issue with the Terraform configuration in the 'Infra' repo that prevented the creation of the AKS cluster where to deploy the Geek Zone app. That issue is now solved, so the deploy jobs can be restored.

How Has This Been Tested?

The k8s cluster has been created by manually running terraform apply

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@giulio-giunta
Copy link
Contributor Author

@jamesgeddes,
Could you please review this PR?
The cicd ran successfully and deployed the application in the AKS cluster, which was spun by Terraform
image

@giulio-giunta giulio-giunta merged commit 75fd07b into main Nov 29, 2023
9 checks passed
@giulio-giunta giulio-giunta deleted the feature-693 branch November 29, 2023 06:49
@giulio-giunta
Copy link
Contributor Author

Thanks @jamesgeddes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore deployment jobs in cicd pipeline
2 participants