Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify email #85

Closed
jamesgeddes opened this issue Nov 12, 2020 · 16 comments · Fixed by #275
Closed

Verify email #85

jamesgeddes opened this issue Nov 12, 2020 · 16 comments · Fixed by #275
Assignees
Labels
P1 Issues that are both high impact and urgent post-registration Something that a member is required to do after they have registered pre-go-live Required for MVP

Comments

@jamesgeddes
Copy link
Contributor

jamesgeddes commented Nov 12, 2020

Allow user to click link in email to verify email ownership.

Email should show as unverified in member_details until verification is complete

Emails should come from hq@geek.zone

@jamesgeddes jamesgeddes added P2 Issues that are high impact but not urgent pre-go-live Required for MVP post-registration Something that a member is required to do after they have registered labels Nov 12, 2020
@jamesgeddes
Copy link
Contributor Author

@jamesgeddes
Copy link
Contributor Author

Would be best to be able to call the verification at a point of our choosing which appears to be easier in django-email-verification

@Freshrojek Freshrojek self-assigned this Nov 15, 2020
@jamesgeddes
Copy link
Contributor Author

@Freshrojek #39 is now in master

@Freshrojek Freshrojek pinned this issue Nov 22, 2020
@Freshrojek Freshrojek unpinned this issue Dec 1, 2020
@Freshrojek
Copy link
Contributor

I'm having trouble, I need to log in in order to verify my email but I can't and can't create a new account with the same email, @jamesgeddes @CarwynNelson have you guys got any tips? thanks in advance!

@Freshrojek
Copy link
Contributor

I'm having trouble, I need to log in in order to verify my email but I can't and can't create a new account with the same email, @jamesgeddes @CarwynNelson have you guys got any tips? thanks in advance!

I'm getting 'User has no member' in line 157 of views.py:
"form": MemberDetailsForm(instance=request.user.member),

@CarwynNelson
Copy link
Contributor

I'm having trouble, I need to log in in order to verify my email but I can't and can't create a new account with the same email, @jamesgeddes @CarwynNelson have you guys got any tips? thanks in advance!

There are a couple ways you could go about it.

There is a file in the project called something like db.sqlite which you can just delete and then run the migrate command.

Another way is to create a superuser account which you can then use to login to the admin panel and delete your user account.

https://djangocentral.com/creating-super-user-in-django/

And finally you could open the db.sqlite file in a sqlite database tool and delete stuff that way.

Personally I just create a superuser account and delete or modify stuff that way.

@CarwynNelson
Copy link
Contributor

I'm having trouble, I need to log in in order to verify my email but I can't and can't create a new account with the same email, @jamesgeddes @CarwynNelson have you guys got any tips? thanks in advance!

I'm getting 'User has no member' in line 157 of views.py:
"form": MemberDetailsForm(instance=request.user.member),

How was this user created? A user will only have a member associated with it if it was created via the registration form, or at least via the Member.create method

@Freshrojek
Copy link
Contributor

I'm having trouble, I need to log in in order to verify my email but I can't and can't create a new account with the same email, @jamesgeddes @CarwynNelson have you guys got any tips? thanks in advance!

There are a couple ways you could go about it.

There is a file in the project called something like db.sqlite which you can just delete and then run the migrate command.

Another way is to create a superuser account which you can then use to login to the admin panel and delete your user account.

https://djangocentral.com/creating-super-user-in-django/

And finally you could open the db.sqlite file in a sqlite database tool and delete stuff that way.

Personally I just create a superuser account and delete or modify stuff that way.

Thanks Carwyn! Created a superuser now and deleted that way

@Freshrojek
Copy link
Contributor

I'm having trouble, I need to log in in order to verify my email but I can't and can't create a new account with the same email, @jamesgeddes @CarwynNelson have you guys got any tips? thanks in advance!

I'm getting 'User has no member' in line 157 of views.py:
"form": MemberDetailsForm(instance=request.user.member),

How was this user created? A user will only have a member associated with it if it was created via the registration form, or at least via the Member.create method

I created it through the registration form

@CarwynNelson
Copy link
Contributor

I'm having trouble, I need to log in in order to verify my email but I can't and can't create a new account with the same email, @jamesgeddes @CarwynNelson have you guys got any tips? thanks in advance!

I'm getting 'User has no member' in line 157 of views.py:
"form": MemberDetailsForm(instance=request.user.member),

How was this user created? A user will only have a member associated with it if it was created via the registration form, or at least via the Member.create method

I created it through the registration form

Hmm.. that is very strange. I would probably have to see what you are doing to get a better idea of some further debugging steps

@jamesgeddes
Copy link
Contributor Author

@Freshrojek Can you record a loom?

@Freshrojek
Copy link
Contributor

Ahh as I was recording a loom, I found out the problem, I hadn't clicked the 'log out' button before I tried to log in - I forgot that once you sign up it has you already logged in.

@jamesgeddes
Copy link
Contributor Author

@Freshrojek How are you getting on with this?

@Freshrojek
Copy link
Contributor

Freshrojek commented Mar 30, 2021

@Freshrojek How are you getting on with this

Tried to send a commit today but was in the library and uni WiFi is something else. Verify email will only work if the registration form is a modelForm and meets some confusing requirements that would mean changing our form, so I'm in the proceeds of creating our own verification function, I have made a code and been able to send it but just gotta verify it now

@jamesgeddes jamesgeddes added P1 Issues that are both high impact and urgent and removed P2 Issues that are high impact but not urgent labels Mar 31, 2021
@jamesgeddes
Copy link
Contributor Author

If you cannot get it to work on-demand, go with sending an email on the registration form. We can improve it later.

@Freshrojek
Copy link
Contributor

With my last commit on the branch, I'm pretty sure it's all done! Sunday when I'm back on hopefully I'll be able to check and make a pull request.

@Freshrojek Freshrojek linked a pull request Apr 16, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Issues that are both high impact and urgent post-registration Something that a member is required to do after they have registered pre-go-live Required for MVP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants