Verify email #275
Verify email #275
Conversation
|
I have a test email if anyone wants the information |
|
One other thing - I think |
|
Sorry to keep mentioning stuff but I also think that all the functions made for the email verification should be moved to its own file. |
Good idea |
The more suggestions the better :) yeah it's only used once but after you mentioned it it probably would be best to have it in a file separately. |
|
@SamWinterhalder Actually, I'm not too sure now as they are both the views for |
|
Good idea, should I log a ticket for it? |
|
gonna have to rebase before merging because all commits need to be signed, so I might need you to look again after rebase lol |
Freshrojek
force-pushed
the
verify-email
branch
from
05558c0
to
2160cb8
Compare
|
Erm, there are a lot of duplicate commits 😅 Could ya |
Freshrojek
force-pushed
the
verify-email
branch
2 times, most recently
from
9710781
to
47904e7
Compare
|
There we go, just got myself in and out of a fine hot git mess 😰 |
|
Just added the welcome email quickly as it needs the celery set-up I have used for the verification email |
Freshrojek
force-pushed
the
verify-email
branch
from
289dd52
to
f2aa052
Compare
|
Since rebasing the celery worker receives the task but it stops there, |
|
and I always keep getting redirected to |
See #282 |
|
Emails seem to have been sent for me:
|
…n. email-verification seems to be easier but when using get_user_model I'm getting a UNIQUE constraint failed: auth_user.username error
…tting the object of the user rather than creating duplicate objects. Next task for this is to get the links and token verification working. Also details for test email i set up are exposed in settings
…n. email-verification seems to be easier but when using get_user_model I'm getting a UNIQUE constraint failed: auth_user.username error
Completed the email verification process now, by using my own method rather than the Django-email-verification or Django-verify-email it means the verification doesn't rely on the user being active or not. This means we can request to verify email through a button on the details page - which is now done.
Now have a template for when the email sends, and sending the email through celery (need to test though)
Updated __init__.py to ensure celery runs on start up, added a broker URL in the settings for celery to use and updated calling the task to send an email in tasks.py instead of using send_mail
Used the migration files from master to generate the same workspace file for pycharm
Updated the duplicate in models, removed the commented @login_required() and added the .idea/ folder to .gitignore
Un-commented recaptcha function
Corrected variable name passed into the html message
Added it under `exclude` so that the user can't change the field manually without verifying their email
|
all rebased @jamesgeddes :) |
Think this branch is ready enough.
I have updated the email sending view to now send through celery using the
tasks.pyfile.To send a verification email you need to set the appropriate settings in your environment for email, then sign up and on the
member_detailspage there will be a button to send a verification email.If you are already verified, the button will no longer be there and you can see the
email verifiedfield to the member model is updated.