Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 249: Payment confirmation email #688

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Issue 249: Payment confirmation email #688

wants to merge 2 commits into from

Conversation

Beloborodova-Anastasiia
Copy link

@Beloborodova-Anastasiia Beloborodova-Anastasiia commented Aug 1, 2023 •
edited
Loading

Description

We automatically send an email to a member when a payment attempt is made - regardless of whether the payment is successful or not.
What was done:

  • Added a function sending email after a successful payment;
  • Added corresponding test.

Related Issue

This resolves #249

Motivation and Context

How Has This Been Tested?

Unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Beloborodova-Anastasiia Beloborodova-Anastasiia requested a review from a team as a code owner August 1, 2023 17:39
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jamesgeddes
Copy link
Contributor

Great work @Beloborodova-Anastasiia, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeddes jamesgeddes jamesgeddes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Payment confirmation email
2 participants
@Beloborodova-Anastasiia @jamesgeddes