Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated GeekZone executor image #707

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Updated GeekZone executor image #707

merged 3 commits into from
Dec 17, 2023

Conversation

giulio-giunta
Copy link
Contributor

Description

The GeekZone executor image needs to be updated to have the GeekZone app deployed in the AKS cluster

Related Issue

"resolves #706 "

Motivation and Context

The new GeekZone executor image links the GeekZone application tag to the pipeline number, as opposed to the "PREVIOUS_CIRCLECI_BUILD" variable that is no longer supported by Circleci.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@giulio-giunta giulio-giunta requested a review from a team as a code owner December 17, 2023 12:12
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 17, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@giulio-giunta
Copy link
Contributor Author

The deployment in "Test" was successful
image

jamesgeddes
jamesgeddes approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@jamesgeddes jamesgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@giulio-giunta giulio-giunta merged commit 802bac1 into main Dec 17, 2023
7 checks passed
@giulio-giunta giulio-giunta deleted the feature-706 branch December 17, 2023 18:57
@giulio-giunta giulio-giunta restored the feature-706 branch January 1, 2024 15:47
giulio-giunta added a commit that referenced this pull request Jan 1, 2024
@giulio-giunta
Revert "Updated GeekZone executor image (#707)"
8afbce4 
This reverts commit 802bac1.
@giulio-giunta giulio-giunta mentioned this pull request Jan 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeddes jamesgeddes jamesgeddes approved these changes

@Freshrojek Freshrojek Awaiting requested review from Freshrojek Freshrojek is a code owner automatically assigned from GeekZoneHQ/q

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update GeekZone executor image
2 participants
@giulio-giunta @jamesgeddes