Issue #919: test and propsed patch

GemTalk · Mar 7, 2024 · d5c4bcc · d5c4bcc
1 parent 20ed167
commit d5c4bcc
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/rowan/src/Rowan-GemStone-LoaderV2/RwGsPatchSet_V2.class.st b/rowan/src/Rowan-GemStone-LoaderV2/RwGsPatchSet_V2.class.st
@@ -933,7 +933,7 @@ RwGsPatchSet_V2 >> addPatchedUnmanagedClassNewVersion: aClassModification inPack
 
 	currentProjectDefinition := aProjectDefinition.
 
-	classesWithNewVersions
+	addedUnmanagedClasses
 		add:
 			((self _classUnmanagedVersioningPatchClass
 				for: aClassModification
@@ -1248,7 +1248,7 @@ RwGsPatchSet_V2 >> installAddedClasses [
         Create a LoadedClass for the new class, add it to the defining LoadedPackage."
 
 	addedClasses do: [:patch |  patch installClassInSystem ].
-	addedUnmanagedClasses do: [ :patch | patch installClassInSystem ]
+	addedUnmanagedClasses do: [ :patch | patch installNewClassVersionInSystem ]
 ]
 
 { #category : 'private - applying' }

diff --git a/rowan/src/Rowan-Tests/RwRowanSample9Test.class.st b/rowan/src/Rowan-Tests/RwRowanSample9Test.class.st
@@ -5962,6 +5962,32 @@ false ifTrue: [
  ]
 ]
 
+{ #category : 'issue 919' }
+RwRowanSample9Test >> testIssue919 [
+	"https://github.com/GemTalk/Rowan/issues/919"
+
+	| loadSpec projectName resolvedProject loadedProjects class |
+	loadSpec := self _loadSpecNamed: 'spec_0001'.
+
+	projectName := loadSpec projectName.
+
+	(Rowan image loadedProjectNamed: projectName ifAbsent: [  ])
+		ifNotNil: [ :proj | Rowan image _removeLoadedProject: proj ].
+
+"resolve project"
+	resolvedProject := loadSpec resolveProject.
+
+"create the unmanaged class"
+	class := Object subclass: 'RowanSample9Class1'
+		instVarNames: #( ivar1 )
+		inDictionary: (Rowan image newOrExistingSymbolDictionaryNamed: self _sampleSymbolDictionaryName1).
+"validate"
+	self assert: class rowanProjectName equals: Rowan unpackagedName.
+
+"load project"
+	loadedProjects := resolvedProject load.
+]
+
 { #category : 'issue 493' }
 RwRowanSample9Test >> testMoveClassBetweenSymDicts_changeDefaulSymDict_2_493 [
 	"https://github.com/dalehenrich/Rowan/issues/493"