Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SequenceableCollection class>>#new:withAll: don't work for OrderedCollection #903

Open
gcotelli opened this issue Sep 5, 2023 · 1 comment

Comments

@gcotelli
Copy link

gcotelli commented Sep 5, 2023

This method is a Rowan extension and it's not working correctly for OrderedCollection. It works ok for ByteArray and Array, but for OrderedCollection, it returns an empty instance.

Here's a test case showing the problem:

testOrderedCollectionNewWithAll

| collection|
collection := OrderedCollection new: 6 withAll: true.
self
  assert: collection size equals: 6;
  assert: (collection allSatisfy: [:each | each ])
@AllenOtis
Copy link
Member

OrderedCollection class needs to reimplement new:withAll: since it reimplements new: in the GemStone base image.

dalehenrich added a commit that referenced this issue Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants