Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For compatiblity with Pharo, Trait definition must write an optional category and packageName to disk ... #938

Open
dalehenrich opened this issue Nov 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@dalehenrich
Copy link
Member

dalehenrich commented Nov 18, 2024

Category is not required and the packageName will not be stored as an attribute, but derived from the name of the package the definition is in ...

For strict compatibility for Pharo, the packageName and category are expected to match(?) ...

For GemStone, the category and packageName are not required ...

Related to internal issue "51233 P3 generategs with traits has confusing interpretation of Trait category"

spec_0084 and spec_0085 are incomplete with respect to Pharo compatibility for Rowan:masterV3.2.

Moving forward spec_0086, spec_0087 and spec_0088 will be the primary examples for Traits.

@dalehenrich dalehenrich added the bug Something isn't working label Nov 18, 2024
@dalehenrich dalehenrich self-assigned this Nov 18, 2024
@dalehenrich
Copy link
Member Author

The implementation of Traits in Rowan3 in branch masterV3.2 was incomplete with respect to Pharo compatibility (namely category and packageName properties in the Trait definition).

For Pharo compatility if a category is defined for a Trait, then the packageName for the Trait will be written to disk.

GemStone and Rowan V3 will ignore a packageName property for a Trait when read (the name of the containing package will be used) and the category property is optional - standard default category ('Kernel'/'User Classes') name used for classes should apply)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant