Fix pval calc for low t values #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lckarssen
added a commit
that referenced
this pull request
Sep 5, 2017
This commit is copied from commit 706764e in Pull Request #3. That PR does more than fixing issue #2, so I decided to split the other parts off into separate commits. - Add omicOUT to the Makefile.am - Fix compiler error about the ifstream pointer check. - Add some omitOUT related files to the Git ignore list. Thanks for Albert Vernon Smith <avsmith@gmail.com> for the fix!
lckarssen
added a commit
that referenced
this pull request
Sep 5, 2017
This commit is copied from commit 706764e in Pull Request #3. That PR does more than fixing issue #2, so I decided to split the other parts off into separate commits. - Add omicOUT to the Makefile.am - Fix compiler error about the ifstream pointer check. - Add some omitOUT related files to the Git ignore list. Thanks for Albert Vernon Smith <avsmith@gmail.com> for the fix!
|
Hi Albert, Thanks again for sending this patch. I finally found the time to look at it in more detail. In order to keep things a bit clean (and let the pull request only fix the actual Issue) I have taken the other parts of your commits and applied them separately on master. Could you rebase your changes on top of the current HEAD of master? Thanks! |
|
yup, miscommited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P-values for T < 1.6 incorrectly calculated. Change to erfc based calculation for all T, no major performance hit detected (in limited testing).
Proposed fix for "fixes #2"