Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large p-values incorrectly approximated #2

Open
avsmith opened this issue Mar 1, 2017 · 1 comment · May be fixed by #3
Open

Large p-values incorrectly approximated #2

avsmith opened this issue Mar 1, 2017 · 1 comment · May be fixed by #3

Comments

@avsmith
Copy link

avsmith commented Mar 1, 2017

In the file Algorithm.cpp, p-values for T less than 1.6 are being approximated by the following (likely for speed reasons):

                if( t < 1.6)
                {
                    t1=4.4-t;
                    ptemp=0.5-0.1*t1*t;
                }
                else
                {
                    ptemp=erfc(t*one_oversqrt2);
                }

However, the approximated p-values for t<1.6 are too high. Plotting p vs t results in a discontinuity at 1.6.
@avsmith avsmith linked a pull request Mar 2, 2017 that will close this issue
Open
@lckarssen
Copy link
Member

Thanks for reporting this and providing a fix! I'll have a look at it next week, trying to see if I can find impact on speed.

lckarssen added a commit that referenced this issue Sep 5, 2017
@lckarssen
Fix compile errors in omicOUT, update Makefile and .gitignore
f696d99 
This commit is copied from commit
706764e in Pull Request #3. That PR
does more than fixing issue #2, so I decided to split the other parts
off into separate commits.

- Add omicOUT to the Makefile.am
- Fix compiler error about the ifstream pointer check.
- Add some omitOUT related files to the Git ignore list.

Thanks for Albert Vernon Smith <avsmith@gmail.com> for the fix!
lckarssen added a commit that referenced this issue Sep 5, 2017
@lckarssen
Fix compile errors in omicOUT, update Makefile and .gitignore
a393e66 
This commit is copied from commit
706764e in Pull Request #3. That PR
does more than fixing issue #2, so I decided to split the other parts
off into separate commits.

- Add omicOUT to the Makefile.am
- Fix compiler error about the ifstream pointer check.
- Add some omitOUT related files to the Git ignore list.

Thanks for Albert Vernon Smith <avsmith@gmail.com> for the fix!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pval calc for low t values avsmith/OmicABELnoMM
2 participants
@avsmith @lckarssen