From c635be7308d9d9c78b226819237442a4d3d2d386 Mon Sep 17 00:00:00 2001
From: Dennis Scheiba <dennis.scheiba@gmx.de>
Date: Fri, 22 Sep 2023 11:36:59 +0200
Subject: [PATCH 1/8] do not allow to delete entry node in backend

---
 caster-back/gencaster/schema.py | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/caster-back/gencaster/schema.py b/caster-back/gencaster/schema.py
index e13f7d59..1a48997a 100644
--- a/caster-back/gencaster/schema.py
+++ b/caster-back/gencaster/schema.py
@@ -294,7 +294,15 @@ async def delete_edge(self, info, edge_uuid: uuid.UUID) -> None:
     async def delete_node(self, info, node_uuid: uuid.UUID) -> None:
         """Deletes a given :class:`~story_graph.models.Node`."""
         await graphql_check_authenticated(info)
-        await story_graph_models.Node.objects.filter(uuid=node_uuid).adelete()
+        node = await story_graph_models.Node.objects.aget(uuid=node_uuid)
+        if node is None:
+            raise Exception(f"Could not find node {node_uuid}")
+        if node.is_entry_node:
+            raise Exception(
+                f"Node {node_uuid} is an entry node which can not be deleted"
+            )
+        await node.adelete()
+        return None
 
     @strawberry.mutation
     async def create_script_cells(

From 549f6ede93e4a74f9b1aa00c4fae97d34842cf35 Mon Sep 17 00:00:00 2001
From: Vinzenz Aubry <vinzenzaubry@gmail.com>
Date: Fri, 22 Sep 2023 21:01:49 -0400
Subject: [PATCH 2/8] Prevent delete entry node with editor

---
 caster-editor/src/components/MenuTabEdit.vue | 24 ++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/caster-editor/src/components/MenuTabEdit.vue b/caster-editor/src/components/MenuTabEdit.vue
index 0b143931..3d71c7cf 100644
--- a/caster-editor/src/components/MenuTabEdit.vue
+++ b/caster-editor/src/components/MenuTabEdit.vue
@@ -28,10 +28,11 @@ import { ElMessage } from "element-plus";
 import { storeToRefs } from "pinia";
 import { ref, type Ref } from "vue";
 import DialogAddNode from "./DialogAddNode.vue";
+import { el } from "element-plus/es/locale";
 
-export type GraphEdit = Pick<Graph, "uuid">;
+export type GraphEdit = Pick<Graph, "uuid" | "nodes">;
 
-defineProps<{
+const props = defineProps<{
   graph: GraphEdit;
 }>();
 
@@ -44,6 +45,19 @@ const showAddNodeDialog: Ref<boolean> = ref(false);
 const deleteNodeMutation = useDeleteNodeMutation();
 const deleteEdgeMutation = useDeleteEdgeMutation();
 
+const checkIfNodeEntry = (nodeUuid: string) => {
+  for (let i = 0; i < props.graph.nodes.length; i++) {
+    if (
+      props.graph.nodes[i].uuid === nodeUuid &&
+      props.graph.nodes[i].isEntryNode
+    ) {
+      return true;
+    } else {
+      return false;
+    }
+  }
+};
+
 const removeSelection = async () => {
   console.log("Removing selection");
 
@@ -60,6 +74,12 @@ const removeSelection = async () => {
   });
 
   selectedNodeUUIDs.value.forEach(async (nodeUuid) => {
+    // compare if to props.graph.nodes and find isEntryNode
+    if (checkIfNodeEntry(nodeUuid)) {
+      ElMessage.error(`Cannot delete entry node.`);
+      return;
+    }
+
     const { error } = await deleteNodeMutation.executeMutation({
       nodeUuid,
     });

From ee5e01356a07bec9c85436da33b0b78bc31a5929 Mon Sep 17 00:00:00 2001
From: Vinzenz Aubry <vinzenzaubry@gmail.com>
Date: Fri, 22 Sep 2023 21:02:49 -0400
Subject: [PATCH 3/8] fixed btn coloring for addnode dialog

---
 caster-editor/src/components/DialogAddNode.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/caster-editor/src/components/DialogAddNode.vue b/caster-editor/src/components/DialogAddNode.vue
index 16af314b..bd064dfc 100644
--- a/caster-editor/src/components/DialogAddNode.vue
+++ b/caster-editor/src/components/DialogAddNode.vue
@@ -71,7 +71,7 @@ const createNode = async () => {
       <template #footer>
         <span class="dialog-footer">
           <ElButton
-            type="danger"
+            type="info"
             @click="() => emit('closed')"
           >Cancel</ElButton>
           <ElButton

From 47140a44b6593130d7bae3aad5aa047418c5a9e0 Mon Sep 17 00:00:00 2001
From: Vinzenz Aubry <vinzenzaubry@gmail.com>
Date: Fri, 22 Sep 2023 21:13:55 -0400
Subject: [PATCH 4/8] fixed typos

---
 caster-editor/src/components/Menu.vue        | 2 +-
 caster-editor/src/components/MenuTabEdit.vue | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/caster-editor/src/components/Menu.vue b/caster-editor/src/components/Menu.vue
index 77c7b793..78f2c70f 100644
--- a/caster-editor/src/components/Menu.vue
+++ b/caster-editor/src/components/Menu.vue
@@ -58,7 +58,7 @@ import MenuTabEdit from "./MenuTabEdit.vue";
 import MenuTabPlay from "./MenuTabPlay.vue";
 import DialogExitGraph from "./DialogExitGraph.vue";
 
-export type GraphMenu = Pick<Graph, "name" | "uuid" | "slugName">;
+export type GraphMenu = Pick<Graph, "name" | "uuid" | "slugName" | "nodes">;
 
 // Props
 defineProps<{
diff --git a/caster-editor/src/components/MenuTabEdit.vue b/caster-editor/src/components/MenuTabEdit.vue
index 3d71c7cf..b1eb0545 100644
--- a/caster-editor/src/components/MenuTabEdit.vue
+++ b/caster-editor/src/components/MenuTabEdit.vue
@@ -28,7 +28,6 @@ import { ElMessage } from "element-plus";
 import { storeToRefs } from "pinia";
 import { ref, type Ref } from "vue";
 import DialogAddNode from "./DialogAddNode.vue";
-import { el } from "element-plus/es/locale";
 
 export type GraphEdit = Pick<Graph, "uuid" | "nodes">;
 

From 94226b2571c14508320457b14cda3aefdd5b12bd Mon Sep 17 00:00:00 2001
From: Vinzenz Aubry <vinzenzaubry@gmail.com>
Date: Fri, 22 Sep 2023 21:39:05 -0400
Subject: [PATCH 5/8] Fixed typing?

---
 caster-editor/src/components/Menu.vue | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/caster-editor/src/components/Menu.vue b/caster-editor/src/components/Menu.vue
index 78f2c70f..b9918edd 100644
--- a/caster-editor/src/components/Menu.vue
+++ b/caster-editor/src/components/Menu.vue
@@ -50,7 +50,7 @@
 
 <script lang="ts" setup>
 import { storeToRefs } from "pinia";
-import type { Graph } from "@/graphql";
+import type { Graph, Node } from "@/graphql";
 import { ref, type Ref } from "vue";
 import { Tab, useInterfaceStore } from "@/stores/InterfaceStore";
 import MenuTab from "./MenuTabHeader.vue";
@@ -58,7 +58,9 @@ import MenuTabEdit from "./MenuTabEdit.vue";
 import MenuTabPlay from "./MenuTabPlay.vue";
 import DialogExitGraph from "./DialogExitGraph.vue";
 
-export type GraphMenu = Pick<Graph, "name" | "uuid" | "slugName" | "nodes">;
+export type GraphMenu = Pick<Graph, "name" | "uuid" | "slugName"> & {
+  nodes: Array<any>;
+};
 
 // Props
 defineProps<{

From d562b2c016de57a47d112776e3cae582827861b4 Mon Sep 17 00:00:00 2001
From: Vinzenz Aubry <vinzenzaubry@gmail.com>
Date: Fri, 22 Sep 2023 21:46:58 -0400
Subject: [PATCH 6/8] removed unused type

---
 caster-editor/src/components/Menu.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/caster-editor/src/components/Menu.vue b/caster-editor/src/components/Menu.vue
index b9918edd..c48ac93e 100644
--- a/caster-editor/src/components/Menu.vue
+++ b/caster-editor/src/components/Menu.vue
@@ -50,7 +50,7 @@
 
 <script lang="ts" setup>
 import { storeToRefs } from "pinia";
-import type { Graph, Node } from "@/graphql";
+import type { Graph } from "@/graphql";
 import { ref, type Ref } from "vue";
 import { Tab, useInterfaceStore } from "@/stores/InterfaceStore";
 import MenuTab from "./MenuTabHeader.vue";

From 7273d6b6cf2ab8ba69d5974d1865e19372c4b577 Mon Sep 17 00:00:00 2001
From: Dennis Scheiba <dennis.scheiba@gmx.de>
Date: Tue, 3 Oct 2023 22:47:40 +0200
Subject: [PATCH 7/8] refactor checkIfNodeEntry into functional style

---
 caster-editor/src/components/MenuTabEdit.vue | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/caster-editor/src/components/MenuTabEdit.vue b/caster-editor/src/components/MenuTabEdit.vue
index b1eb0545..470d6cf7 100644
--- a/caster-editor/src/components/MenuTabEdit.vue
+++ b/caster-editor/src/components/MenuTabEdit.vue
@@ -44,17 +44,10 @@ const showAddNodeDialog: Ref<boolean> = ref(false);
 const deleteNodeMutation = useDeleteNodeMutation();
 const deleteEdgeMutation = useDeleteEdgeMutation();
 
-const checkIfNodeEntry = (nodeUuid: string) => {
-  for (let i = 0; i < props.graph.nodes.length; i++) {
-    if (
-      props.graph.nodes[i].uuid === nodeUuid &&
-      props.graph.nodes[i].isEntryNode
-    ) {
-      return true;
-    } else {
-      return false;
-    }
-  }
+const checkIfNodeEntry = (nodeUuid: string): boolean => {
+  return (
+    props.graph.nodes.find((x) => x.uuid === nodeUuid)?.isEntryNode ?? false
+  );
 };
 
 const removeSelection = async () => {

From 5de83f02a0b11b9686ab7394c800f102507f0b8d Mon Sep 17 00:00:00 2001
From: Dennis Scheiba <dennis.scheiba@gmx.de>
Date: Tue, 3 Oct 2023 22:48:58 +0200
Subject: [PATCH 8/8] fix nodes type for MenuTabEdit

---
 caster-editor/src/components/Menu.vue        | 5 ++---
 caster-editor/src/components/MenuTabEdit.vue | 6 ++++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/caster-editor/src/components/Menu.vue b/caster-editor/src/components/Menu.vue
index c48ac93e..b3e7b430 100644
--- a/caster-editor/src/components/Menu.vue
+++ b/caster-editor/src/components/Menu.vue
@@ -57,10 +57,9 @@ import MenuTab from "./MenuTabHeader.vue";
 import MenuTabEdit from "./MenuTabEdit.vue";
 import MenuTabPlay from "./MenuTabPlay.vue";
 import DialogExitGraph from "./DialogExitGraph.vue";
+import type { GraphEdit } from "./MenuTabEdit.vue";
 
-export type GraphMenu = Pick<Graph, "name" | "uuid" | "slugName"> & {
-  nodes: Array<any>;
-};
+export type GraphMenu = Pick<Graph, "name" | "uuid" | "slugName"> & GraphEdit;
 
 // Props
 defineProps<{
diff --git a/caster-editor/src/components/MenuTabEdit.vue b/caster-editor/src/components/MenuTabEdit.vue
index 470d6cf7..80186cc5 100644
--- a/caster-editor/src/components/MenuTabEdit.vue
+++ b/caster-editor/src/components/MenuTabEdit.vue
@@ -21,7 +21,7 @@
 </template>
 
 <script setup lang="ts">
-import type { Graph } from "@/graphql";
+import type { Graph, Node } from "@/graphql";
 import { useDeleteEdgeMutation, useDeleteNodeMutation } from "@/graphql";
 import { useInterfaceStore } from "@/stores/InterfaceStore";
 import { ElMessage } from "element-plus";
@@ -29,7 +29,9 @@ import { storeToRefs } from "pinia";
 import { ref, type Ref } from "vue";
 import DialogAddNode from "./DialogAddNode.vue";
 
-export type GraphEdit = Pick<Graph, "uuid" | "nodes">;
+export type GraphEdit = Pick<Graph, "uuid"> & {
+  nodes: Pick<Node, "uuid" | "isEntryNode">[];
+};
 
 const props = defineProps<{
   graph: GraphEdit;