-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC/projections: Make projection name consistent #8567
DOC/projections: Make projection name consistent #8567
Conversation
Hmm, lots of changes here. While I agree on dropping the word |
https://en.wikipedia.org/wiki/List_of_map_projections Looking at this wikipedia page, I think "Mercator" is the projection name and "cylindrical" is just the projection property. So I feel we should use the official projection names listed on this Wikipedia page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WalterHFSmith Walter, do you have opinion on dropping "equal-area" in some projection names?
Dear All, So what is the problem we are trying to solve? A standardization of nomenclature? |
Thanks Walter. I won't answer what the problem tried to be solved because I'm not sure either. And from what you wrote I deduce that we should not drop the Equal-Area" from names and that instead it should be understood as that the implementation is using Authalic sphere. In order to see the proposed changes click on the "Files changed" at the top of this page |
Thanks @WalterHFSmith for your very detailed comment! The idea of this PR is to make the projection name consistent between the projection table (https://docs.generic-mapping-tools.org/dev/reference/map-projections.html) and the projection explanations. For example,
|
OK, so things are now clear on my mind (mean, opinion). We should not drop the "equal area" from names in the table as it provides important information. The projection description doesn't have it in the header but has in the description. We could drop the Finally the Even the |
Yvonne and Joaquim, As far as I know, the only projection known as Mercator is a cylindrical projection, so perhaps one can drop the term "cylindrical" from Mercator, if that helps to standardize the nomenclature. But note that there are many cylindrical projections (conformal = Mercator, but also equal area and others) and they can be in various aspects (cylinder tangent on any great circle, not necessarily the Equator), so in general we cannot drop "cylindrical" from a name. Sorry, these comments from me are not much help. I am glad you are doing this. Walter |
I'm fine with this. |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@yvonnefroehlich Please make sure that all headers in |
I apologise for the delay with this PR, I will try to continue here at the end of the week (or the weekend). Thanks a lot for all yor comments and suggestions so far 🙂! |
Done in the commits 8e9d524 ( |
Please, no not remove the |
Done in commit 40930b4. Hm. At the moment I am a bit lost regarding how I should actually change the projection names to make them more consistent /: . |
Thanks. The
Consistent with what? As I mentioned before, in my view, a table summary does not need to be exactly equal the headers in the projections page. But I understand you and confess to be also confused by now. IMO, things like they were served us perfectly during > 30 years (were written by the author) and didn't need any particular change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should keep the projection names unchanged. The suggestions below revert most changes.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Description of proposed changes
Related to the points 3. and 4. of GenericMappingTools/pygmt#3405 (comment).
Currently the projection names are adjusted based on the name used in the projection table.
Related PyGMT PR at GenericMappingTools/pygmt#3407.
Reminders