Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Generate the list of supported fonts dynamically from codes #3406

Merged
merged 3 commits into from
Sep 1, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Aug 21, 2024

Description of proposed changes

Similar to #3409, but for the list of supported fonts. Changes in doc/conf.py and doc/_static/style.css are the same as in #3409.

Preview:

@seisman seisman force-pushed the doc/fonts branch 5 times, most recently from c039280 to a14da4f Compare August 21, 2024 10:30
@seisman seisman changed the title WIP: Improve the fonts documentation WIP: Generate the list of supported fonts dynamically Aug 21, 2024
@seisman seisman changed the title WIP: Generate the list of supported fonts dynamically WIP: Generate the list of supported fonts dynamically in the documentation Aug 21, 2024
@seisman seisman changed the title WIP: Generate the list of supported fonts dynamically in the documentation Generate the list of supported fonts dynamically in the documentation Aug 23, 2024
@seisman seisman changed the title Generate the list of supported fonts dynamically in the documentation DOC: Generate the list of supported fonts dynamically from codes Aug 23, 2024
@seisman seisman added this to the 0.13.0 milestone Aug 23, 2024
@seisman seisman added documentation Improvements or additions to documentation maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Aug 24, 2024
@seisman seisman marked this pull request as ready for review August 24, 2024 09:48
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Aug 27, 2024
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Aug 28, 2024
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea to generate the table with the font samples directly in PyGMT 🙂!

doc/techref/fonts.md Show resolved Hide resolved
doc/techref/fonts.md Outdated Show resolved Hide resolved
doc/techref/fonts.md Outdated Show resolved Hide resolved
doc/techref/fonts.md Outdated Show resolved Hide resolved
font="Helvetica-Bold",
)
# Fonts
for i, font in enumerate(fonts):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know that, it is possible to use variables defined in one code-cell in the following code-cells.

doc/techref/fonts.md Outdated Show resolved Hide resolved
doc/techref/fonts.md Outdated Show resolved Hide resolved
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman
Copy link
Member Author

seisman commented Aug 30, 2024

Need to merge #3418 first.

@seisman seisman merged commit 93f0503 into main Sep 1, 2024
10 checks passed
@seisman seisman deleted the doc/fonts branch September 1, 2024 07:02
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants