Wrap GMT's standard data type GMT_CUBE for cubes #3150
Draft
+141
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
force-pushed
the
datatypes/gmtcube
branch
from
fe976e4
to
1c5df8c
Compare
michaelgrund
reviewed
Apr 2, 2024
seisman
force-pushed
the
datatypes/gmtcube
branch
from
499c519
to
b59efe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3338, but for wrapping
GMT_CUBE. In this PR, we focus on wrapping the GMT_CUBE structure and will implement the to_dataarray method in the future.There are two known issues here:
lib.call_module("read", "@cube.nc out.nc -Tu")for cubes. The similar command works well for grids and images. It's likely an upstream bug.datastill makes no sense yet. Maybe upstream bug or not.