Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sequence_plus converter from kwargs_to_string #3207

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 28, 2024

Description of proposed changes

After #3116, sequence_plus is no longer used in the project. It also makes no sense to allow a "+"-separated sequence as arguments, since it's not Pythonic.

@seisman seisman added deprecation Deprecating a feature final review call This PR requires final review and approval from a second reviewer labels Apr 28, 2024
@seisman seisman added this to the 0.12.0 milestone Apr 28, 2024
pygmt/helpers/decorators.py Outdated Show resolved Hide resolved
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 28, 2024
@seisman seisman merged commit d58720a into main Apr 28, 2024
17 of 19 checks passed
@seisman seisman deleted the deprecate/sequence_plus branch April 28, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants