-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine the Oblique Mercator projection pages into one page #3451
Conversation
The projection pole is set by *lonp/latp*. | ||
""" | ||
|
||
# %% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it's a little weird to show three mini maps in one gallery thumbnail image (https://pygmt-dev--3451.org.readthedocs.build/en/3451/projections/index.html#cylindric-projections). Since it's just three different ways to specify one projection, maybe we can show three separate maps in this example and only show one of them in the gallery summary page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I combined the three maps into one figure, because the maps for the options Oa and Ob are quite high. And having all three maps in the current size below each other makes the website quite long. But your are right, the thumbnail image looks not optimal.
In commit cd15b7d I tested showing separate maps for using a much smaler sizes for the maps. For the thumbnail image I picked the map for Oc, as the ascept ratio seems to fit best to the thumbnail image card.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And having all three maps in the current size below each other makes the website quite long.
I prefer to have the figure below each subsection, which is easier to read IMHO. Let's hear what others think about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I have missed this point from your first review comment here. I just worked on removing the subplot. If having separate code blocks within each subsection, I think it's also OK to show the maps separatly, even though the maps have a larger height. However, having them all tree below each other at the end looked not good.
Togther at the end | Separatly within each subsection |
---|---|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new layout.
Do we also want to combine the Cartesian projection / transformation (linear, logarithmic, and exponential) into one page? |
I prefer separate pages for them so that we can show all of them in the gallery page. |
Description of proposed changes
This PR aims to combine the three documentation pages for the Oblique Mercator projection (Oa, Ob, Oc) into one common page. For the idea / context see #3407 (comment)
Preveiw:
Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code