Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix earth_day_01d_p to earth_day_01d #3471

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix earth_day_01d_p to earth_day_01d #3471

merged 1 commit into from
Sep 30, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 30, 2024

Unlike other remote datasets, the earth_day dataset only provides pixel-registered images. So, its full syntax should be @earth_day_01d rather than @earth_day_01d_p (ref: https://www.generic-mapping-tools.org/remote-datasets/earth-daynight.html), although the original GeoTIFF files are named like earth_day_01d_p.tif (https://oceania.generic-mapping-tools.org/server/earth/earth_day/).

This PR fixes earth_day_01d_p to earth_day_01d

@seisman seisman added the maintenance Boring but important stuff for the core devs label Sep 30, 2024
@seisman seisman added this to the 0.14.0 milestone Sep 30, 2024
@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label Sep 30, 2024
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing user-facing I think, so added skip-changelog.

@seisman seisman merged commit 61f86e8 into main Sep 30, 2024
26 checks passed
@seisman seisman deleted the fix/earth-day branch September 30, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants