Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be interesting to allow the use of models like:
Where the
cover
is effectively optional and by defaultmissing
. Unfortunately,SearchLight.jl/src/SearchLight.jl
Line 394 in 4e001f2
blocks this from working, as
oftype(Book.cover, x)
will callconvert(Missing, x)
which doesn't work forx
being e.g. a String.This PR changes that behavior in that we convert to the type of the field, rather than the type of its default value. The added function
_union_convert
handles cases like converting aFloat64
toUnion{Int,Nothing}
, which would not work withBase.convert
.