"Symbol-renaming" in the editor

[humdingerb]

The "Rename symbol..." context menu item is enabled on any string that is right-clicked. For example, you can right-click on the "false" in fOpenedInEditor(false) and the rename window pops up where you can rename "false".
Nothing gets renamed though, because that is not a valid symbol.

Or, let's say you're in App.cpp and have the line
MainWindow* mainWindow = new MainWindow()
The MainWindow class is from the included MainWindow.h. You can still invoke "Rename symbol" on it, but it won't be renamed in the end...

Is this something we just have to live with, and the experienced user will know what can actually be renamed?

Or should the symbol renaming be confined to the Outline pane? At least there, only the actually renamable symbols are listed.

[jackburton79]

The "Rename symbol..." context menu item is enabled on any string that is right-clicked. For example, you can right-click on the "false" in fOpenedInEditor(false) and the rename window pops up where you can rename "false".
Nothing gets renamed though, because that is not a valid symbol.

Or, let's say you're in App.cpp and have the line
MainWindow* mainWindow = new MainWindow()
The MainWindow class is from the included MainWindow.h. You can still invoke "Rename symbol" on it, but it won't be renamed in the end...

Is this something we just have to live with, and the experienced user will know what can actually be renamed?

Or should the symbol renaming be confined to the Outline pane? At least there, only the actually renamable symbols are listed.

The best user experience would be only showing the rename menuitem if the symbol can be renamed, but given the asynchronous nature of these things, it might not be feasible.
We'll try to come up with a solution, anyway.

[humdingerb]

Yeah. Which symbols can actually be renamed? Only the ones defined in the files .h file?
As I mentioned, you cannot rename the MainWindow() class in the App.cpp file, even though it's a proper symbol.
If so, it may be best to just have the "Rename symbol" in the Outline context menu. At least there you can be 100% you can only invoke it on valid symbols.

[jackburton79]

In theory you could rename all symbols.
Let's see if we can fix disabling the rename when it's not available before settling for a less-than-optimal solution

[humdingerb]

👍