Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change panel sizes logic #55

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Change panel sizes logic #55

merged 2 commits into from
Apr 4, 2024

Conversation

Bo-Duke
Copy link
Member

@Bo-Duke Bo-Duke commented Mar 26, 2024

Simplified panel sizes logic with a less dynamic but more map-centric layout.

Before :

  • large screen, no content open : 1/3 filters, 2/3 map
  • large screen, content open : 1/3 filters, 1/3 content, 1/3 map
  • medium screen, no content open : 1/2 filters, 1/2 map
  • medium screen, content open : 1/2 filters, 1/2 swappable section between content and map with the nav menu
  • small screen : each section takes 100%, swappable with the nav menu

After :

  • Large : Filters at fixed width, content at fixed width if open, map takes the rest of the width
  • Medium screens : 1/2 filters, 1/2 content, 1/2 map, swappable with the nav menu
  • Small screen : each section takes 100%, swappable with the nav menu
Screenshots

Screenshot 2024-03-26 at 16 43 02

Screenshot 2024-03-26 at 16 42 09

Screenshot 2024-03-26 at 16 42 21

Screenshot 2024-03-26 at 16 42 55

Screenshot 2024-03-26 at 16 42 42

Other changes :

  • Fix contribution popup going ouside viewport
  • Fix filter input shrinking too much on small filters panels
  • Fix contribution popup opening too fast on hover (and thus closing itself when you click instead of hover)
  • Move nav menu above content and make it more visible on white background
  • Fix close button not showing when multiple pictures are in details

@Bo-Duke Bo-Duke requested a review from dtrucs March 26, 2024 15:47
Copy link
Contributor

@dtrucs dtrucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Bo-Duke Bo-Duke merged commit 1263535 into main Apr 4, 2024
2 checks passed
@Bo-Duke Bo-Duke deleted the change_panel_sizes branch April 4, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants