Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map interactions enhancements #59

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Map interactions enhancements #59

merged 5 commits into from
Apr 9, 2024

Conversation

Bo-Duke
Copy link
Member

@Bo-Duke Bo-Duke commented Apr 8, 2024

Change tooltip + popup behaviour to only tooltip with better UX : metadata, thumbnail etc.

Screenshot 2024-04-08 at 18 34 19

@Bo-Duke Bo-Duke requested a review from dtrucs April 8, 2024 16:42
@Bo-Duke Bo-Duke marked this pull request as ready for review April 8, 2024 16:42
src/components/details.page.tsx Outdated Show resolved Hide resolved
@Bo-Duke
Copy link
Member Author

Bo-Duke commented Apr 9, 2024

  • When panning, tooltips may stay open
    hacky fix, problem is known and fixed on leaflet but not available on a stable release -> https://github.com/Leaflet/Leaflet/pull/9154
  • Try with a smaller img size? At least on tablet / mobile
  • flex-wrap or at least some way to better handle metadata chips

@Bo-Duke Bo-Duke requested a review from dtrucs April 9, 2024 13:49
src/components/map/geometry-item.tsx Outdated Show resolved Hide resolved
src/components/map/geometry-item.tsx Outdated Show resolved Hide resolved
src/components/metadata-list.tsx Outdated Show resolved Hide resolved
src/styles/globals.css Show resolved Hide resolved
src/styles/globals.css Show resolved Hide resolved
src/styles/globals.css Show resolved Hide resolved
@Bo-Duke Bo-Duke merged commit ef0c2d9 into main Apr 9, 2024
2 checks passed
@Bo-Duke Bo-Duke deleted the map_interactions branch April 9, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants