Add new observation form for custom observations #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo-Duke
force-pushed
the
new_observation_types
branch
4 times, most recently
from
bc0db61
to
72d19ec
Compare
Bo-Duke
force-pushed
the
new_observation_types
branch
from
72d19ec
to
40f9a78
Compare
…l_pages Feat: Add button to redirect user to external page if link on content
feat: add external uri button on Station
dtrucs
reviewed
May 13, 2024
| ): Promise<ObservationDetails | null> { | ||
| const schema = await fetchObservation(type); | ||
| const detailsList = await fetchObservationDetails(type); | ||
| const values = detailsList?.find(detail => detail.id === parseInt(id)); |
There was a problem hiding this comment.
Suggested change
| const values = detailsList?.find(detail => detail.id === parseInt(id)); | |
| const values = detailsList?.find(detail => detail.id === Number(id)); |
or parseInt(id, 10))
| label: (schema?.json_schema_form.properties?.[key] as any)?.title, | ||
| })), | ||
| id, | ||
| contributedAt: values?.contributed_at, |
There was a problem hiding this comment.
Optional chaining seems useless with the early return line 90
Comment on lines
+86
to
+87
| const schema = await fetchObservation(type); | ||
| const detailsList = await fetchObservationDetails(type); |
There was a problem hiding this comment.
Maybe you can use a Promise.all to parallelize queries?
Comment on lines
+111
to
+120
| const observation = await fetchObservation(id); | ||
| return { | ||
| ...observation, | ||
| json_schema_form: { | ||
| ...observation?.json_schema_form, | ||
| properties: { | ||
| ...observation?.json_schema_form?.properties, | ||
| }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Maybe it's more readable to remove all optional chaining by using an early return if observation === null
Comment on lines
+73
to
+82
| const station = await fetchStation(id); | ||
| const observations = await fetchStationObservations(id); | ||
| if (station) { | ||
| return { | ||
| ...station, | ||
| observations, | ||
| }; | ||
| } else { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Suggested change
| const station = await fetchStation(id); | |
| const observations = await fetchStationObservations(id); | |
| if (station) { | |
| return { | |
| ...station, | |
| observations, | |
| }; | |
| } else { | |
| return null; | |
| } | |
| const station = await fetchStation(id); | |
| if (!station) { | |
| return null; | |
| }; | |
| const observations = await fetchStationObservations(id); | |
| return { | |
| ...station, | |
| observations, | |
| }; |
Or Promise.all the queries
| @@ -34,10 +35,12 @@ | |||
| "next": "^13.5.4", | |||
| "next-intl": "2.15.0-beta.5", | |||
| "next-themes": "^0.2.1", | |||
| "node-fetch": "^3.3.2", | |||
dtrucs
requested changes
Nov 4, 2024
Comment on lines
+15
to
27
| if ( | ||
| properties === null || | ||
| (!properties.name && !properties.category && !properties.label) | ||
| ) { | ||
| return null; | ||
| } | ||
| if (layer.type === undefined || !layer.url || !properties.id) { | ||
| return <Tooltip>{properties.name ?? properties.category}</Tooltip>; | ||
| return ( | ||
| <Tooltip> | ||
| {properties.name ?? properties.category ?? properties.label} | ||
| </Tooltip> | ||
| ); | ||
| } |
There was a problem hiding this comment.
const label = properties?.name || properties?.category || properties?.label;
if (!label) {
return null;
}
// [...]
return (<Tooltip>{label}</Tooltip>
src/components/observation-cta.tsx
Outdated
| const [observations, setObservations] = useState<Observation[]>([]); | ||
|
|
||
| useEffect(() => { | ||
| getObservations().then(res => setObservations(res)); |
There was a problem hiding this comment.
To do this, we need useQuery or its equivalent
| }?${params.toString()}`} | ||
| title={observation.label} | ||
| > | ||
| {observation.description ?? ''} |
There was a problem hiding this comment.
Without description, it results an empty link?
There was a problem hiding this comment.
Description should be a prop of ListItem
dtrucs
reviewed
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.