Skip to content

Commit

Permalink
[win32] RP_ShellPropSheetExt.cpp: Really revert the ranged for change.
Browse files Browse the repository at this point in the history
Need to add pFields_cend to where it's reverted, since the first loop
was *not* reverted.

This fixes a regression from commit 2d51365.
([librpbase] RomFields, RomMetaData: Add begin()/end() aliases that return const_iterator.)
  • Loading branch information
GerbilSoft committed Nov 2, 2024
1 parent 52ca8c2 commit 93692e3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/win32/RP_ShellPropSheetExt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1923,6 +1923,7 @@ void RP_ShellPropSheetExt_Private::initDialog(void)

int fieldIdx = 0; // needed for control IDs
auto iter_desc = t_desc_text.cbegin();
const auto pFields_cend = pFields->cend();
for (auto iter = pFields->cbegin(); iter != pFields_cend; ++iter, ++iter_desc, fieldIdx++) {
assert(iter_desc != t_desc_text.cend());
const RomFields::Field &field = *iter;
Expand Down

0 comments on commit 93692e3

Please sign in to comment.