From 93692e3369d269c0c08dffe16088945b6eb07c6c Mon Sep 17 00:00:00 2001 From: David Korth Date: Sat, 2 Nov 2024 00:02:27 -0400 Subject: [PATCH] [win32] RP_ShellPropSheetExt.cpp: Really revert the ranged `for` change. Need to add pFields_cend to where it's reverted, since the first loop was *not* reverted. This fixes a regression from commit 2d51365fc5bc9504d9186a7231b16f6a556afc0d. ([librpbase] RomFields, RomMetaData: Add begin()/end() aliases that return const_iterator.) --- src/win32/RP_ShellPropSheetExt.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/win32/RP_ShellPropSheetExt.cpp b/src/win32/RP_ShellPropSheetExt.cpp index 702dacf4f..44291c6bc 100644 --- a/src/win32/RP_ShellPropSheetExt.cpp +++ b/src/win32/RP_ShellPropSheetExt.cpp @@ -1923,6 +1923,7 @@ void RP_ShellPropSheetExt_Private::initDialog(void) int fieldIdx = 0; // needed for control IDs auto iter_desc = t_desc_text.cbegin(); + const auto pFields_cend = pFields->cend(); for (auto iter = pFields->cbegin(); iter != pFields_cend; ++iter, ++iter_desc, fieldIdx++) { assert(iter_desc != t_desc_text.cend()); const RomFields::Field &field = *iter;