Skip to content

Commit

Permalink
[win32] Add a few more classes to InitCommonControlsEx().
Browse files Browse the repository at this point in the history
ConfigDialog: Add ICC_USEREX_CLASSES for e.g. ComboBoxEx,
which is used by LanguageComboBox. I haven't seen any issues
without this, but request it just in case.

RP_ShellPropSheetExt: No additions; just reformat it.
  • Loading branch information
GerbilSoft committed Jan 11, 2025
1 parent 1d7eaab commit 9d2129e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/win32/RP_ShellPropSheetExt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1679,8 +1679,11 @@ void RP_ShellPropSheetExt_Private::initDialog(void)
// Reference: https://docs.microsoft.com/en-us/windows/win32/api/commctrl/ns-commctrl-initcommoncontrolsex
INITCOMMONCONTROLSEX initCommCtrl;
initCommCtrl.dwSize = sizeof(initCommCtrl);
initCommCtrl.dwICC = ICC_LISTVIEW_CLASSES | ICC_LINK_CLASS |
ICC_TAB_CLASSES | ICC_USEREX_CLASSES;
initCommCtrl.dwICC =
ICC_LISTVIEW_CLASSES |
ICC_LINK_CLASS |
ICC_TAB_CLASSES |
ICC_USEREX_CLASSES;
// TODO: Also ICC_STANDARD_CLASSES on XP+?
InitCommonControlsEx(&initCommCtrl);

Expand Down
1 change: 1 addition & 0 deletions src/win32/config/ConfigDialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ ConfigDialogPrivate::ConfigDialogPrivate()
ICC_LISTVIEW_CLASSES |
ICC_LINK_CLASS |
ICC_TAB_CLASSES |
ICC_USEREX_CLASSES |
ICC_PROGRESS_CLASS;

// TODO: Also ICC_STANDARD_CLASSES on XP+?
Expand Down

0 comments on commit 9d2129e

Please sign in to comment.