Factor out DatastoreResource class

[dafeder]

Fixes #4359

Describe your changes

Remove DatastoreResource class, use DataResource for everything. Note that any class or function that expected a DatastoreResource object now expects a DataResource object. So any custom code that, for instance, builds a datastore DatabaseTable object will need to be slightly refactored.

Other changes to note:

• AbstractDatabaseTable::setTable() is now public. We should use this directly instead of calling ::count() (as we do currently in some places) to indirectly create a database table.
• DictionaryEnforcer now requires the dkan.datastore.database_table_factory service

Please override the CC warnings when reviewing, they are due to CC getting confused by the ReturnTypeMayChange attribute. May be an issue with CC config.

QA Steps

Nothing to QA, everything should still work as it did before from user's perspective.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

• I have updated or added tests to cover my code
• I have updated or added documentation

[dafeder]

Currently debugging failing MySqlQueryDownloadControllerTest, which I think just happens to be the first test to run that tries to run a query. It fails at AbstractDatabaseTable::setTable(), I think something is making the perspective be local_file when it should be something else? It can't get a schema anyway.

[dafeder]

Some progress. Need to redo QueryDownloadControllerTest somehow... not so easy to use fake resource names because table name is no longer based on an ID in the DatastoreResource class that we can simply control via the constructor.

[paul-m]

Drupal\Tests\datastore\Unit\Storage\DatabaseTableFactoryTest still creates a DatastoreResource.

[paul-m]

Let's add to the docblock of Drupal\datastore\Storage\DatabaseTableFactory::getInstance() that the resource must be a DataResource object.

[paul-m]

Drupal\Tests\datastore\Unit\Plugin\QueueWorker\ImportJobTest spends a lot of time making DatastoreResource objects.

Drupal\Tests\datastore\Unit\Service\Info\ImportInfoTest too.

Basically search the codebase for DatastoreResource and you'll see a bunch of tests.

[dafeder]

Let's add to the docblock of Drupal\datastore\Storage\DatabaseTableFactory::getInstance() that the resource must be a DataResource object.

@paul-m see 2594e68