Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Verify the correct deps are peerDependencies #294

Open
3 tasks
benjamincharity opened this issue Aug 26, 2020 · 1 comment
Open
3 tasks

Dependencies: Verify the correct deps are peerDependencies #294

benjamincharity opened this issue Aug 26, 2020 · 1 comment

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Aug 26, 2020

EDIT: Something larger is at play. Dependencies are getting added that are not included in the source files. It seems to be connected to the story files.

To reproduce:

  • Build the button package
  • Notice that items like @terminus/spacing is added to dependencies despite not being imported.
  • Delete the button.stories.ts file
  • Rebuild the button package
  • Notice that @terminus/spacing is no longer present

Looking over the generated package.json for the paginator and it seems there are several items listed as dependencies that should be peer dependencies.

  • Update all packages package.json file with the correct dependencies and peer deps
    • Check the publish packages for the current lists
  • Compile all packages
  • Check the compiled package.json files and add any missing dep or peerDep to the schematic
@benjamincharity
Copy link
Contributor Author

NOTE: I don't think it's as simple as removing story files - not sure where some deps are coming from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant