Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks when a domain is added without a dot in the name #4

Open
MatthewHager opened this issue Jan 21, 2015 · 1 comment
Open

Breaks when a domain is added without a dot in the name #4

MatthewHager opened this issue Jan 21, 2015 · 1 comment

Comments

@MatthewHager
Copy link
Contributor

If we can't fix this we need to then not allow this to happen in the UI. Is it possible to make the aliases inside the VM have some sort of extension on them so the ones exposed to the host can be without a dot?

@ergonlogic
Copy link
Member

This should already be blocked in the UI (in the 0.3.x branch), with the introduction of the 'hosting_valkyrie' module. We'll need to also block such site names in the CLI.

I'd hesitate to try and alter the alias names in the VM, since this is core Aegir behaviour, and will likely result in a number of unintended side-effects.

@ergonlogic ergonlogic added this to the 0.6.0 milestone Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants