-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to include coveralls #62
Conversation
Trying to make it work with: https://github.com/coverallsapp/coverage-reporter |
So I think this is working now: https://coveralls.io/jobs/147503738 but I suppose I need some way to communicate this |
@tomato42 seeing as this was your suggestion, do you have a "favourite way" to communicate the output from the CLI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coverage runs should be part of the normal runs; we use coveralls to combine runs from different environments into one coherent sum total, so we don't want a new Actions job, we want to modify existing ones that test with different python versions
one tricky part is that after you create steps to upload the individual job results to coveralls, like so: you need to then tell coveralls that all jobs finished and the test run is ready: |
I'm finishing for the day now, I might pick this back up later. Feel free to tweak if you want. |
Signed-off-by: Hubert Kario <hkario@redhat.com>
Fixed it up. |
Thanks for fixing this for me |
No description provided.