make sure the benchmark scripts continue to work #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hubert Kario <hkario@redhat.com>
|
My only concern here is that the benchmarks are pretty slow -- should we have some option to run them with a very low iteration count for benchmarking (maybe pass an arg for number of rounds for the benchmark?) |
|
they did finish in 1m 30s, while the regular tests with coverage enabled finished in between 2m 30s to 3m (see current master); they won't be the bottleneck 😃 |
|
OK dokey, we can merge this for now then and then in the future dampen the number of calls if we wish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we change API I keep on forgetting about the benchmark scripts, include them in CI to make sure they continue to work