Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSK-3609 Avoid redundant questions in data generation #1990

Merged
merged 24 commits into from
Oct 31, 2024

Conversation

JiaenLiu
Copy link
Contributor

@JiaenLiu JiaenLiu commented Jul 24, 2024

Description

One fix to avoid the duplicated question generation in RAGET by assigning non-duplicated seed documents for each question generator during the question generation.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

Co-authored-by: Matteo <matteo.dora@ieee.org>
@JiaenLiu JiaenLiu requested review from mattbit and pierlj July 24, 2024 09:02
@JiaenLiu JiaenLiu self-assigned this Jul 24, 2024
Copy link

linear bot commented Jul 24, 2024

@rabah-khalek
Copy link
Contributor

CI still failing, try adding the lockfile label to regenerate the pdm.lock

@rabah-khalek rabah-khalek added the Lockfile Temporary label to update pdm.lock label Aug 14, 2024
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Aug 14, 2024
@henchaves henchaves added the Lockfile Temporary label to update pdm.lock label Aug 19, 2024
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Aug 19, 2024
@henchaves henchaves added the Lockfile Temporary label to update pdm.lock label Aug 19, 2024
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Aug 19, 2024
Copy link

sonarcloud bot commented Aug 30, 2024

@henchaves henchaves added the Lockfile Temporary label to update pdm.lock label Sep 13, 2024
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Sep 13, 2024
@henchaves henchaves added the Lockfile Temporary label to update pdm.lock label Oct 1, 2024
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Oct 1, 2024
@henchaves henchaves removed the request for review from rabah-khalek October 30, 2024 13:17
@henchaves henchaves assigned henchaves and unassigned JiaenLiu Oct 30, 2024
@mattbit
Copy link
Member

mattbit commented Oct 31, 2024

QAing!

Copy link

sonarcloud bot commented Oct 31, 2024

@henchaves henchaves merged commit 4f88d80 into main Oct 31, 2024
17 checks passed
@henchaves henchaves deleted the GSK-3609-Avoid-redundant-questions-in-data-generation branch October 31, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants