Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static-checks CI job #214

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix static-checks CI job #214

merged 1 commit into from
Oct 4, 2024

Conversation

Malcolmnixon
Copy link
Contributor

@Malcolmnixon Malcolmnixon commented Oct 2, 2024 •
edited
Loading

This PR fixes issue #212. Specifically it:

  • Updates to ubuntu-22.04 (the same version as godotengine) to support the .clang-format settings
  • Fixes the clang-format violations

Unfortunately while clang-format hasn't been correctly enforced we've had 21 source files committed with minor clang-format violations.

@BastiaanOlij
Copy link
Member

I'm going to let others see if they are happy with this but I think this is good to merge. Big fan of clang format, but timing is always a pain for these types of changes.

dsnopek
dsnopek approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This looks good to me. We don't have that many open PRs, so I think this is an OK time to merge this.

devloglogan
devloglogan approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@devloglogan devloglogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching this. :)
Now seems as good a time as any to merge this.

@Malcolmnixon Malcolmnixon merged commit b9262f6 into GodotVR:master Oct 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@devloglogan devloglogan devloglogan approved these changes

@m4gr3d m4gr3d Awaiting requested review from m4gr3d

@BastiaanOlij BastiaanOlij Awaiting requested review from BastiaanOlij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Malcolmnixon @BastiaanOlij @dsnopek @devloglogan