Fix ImmutableField warnings

Gold856 · Jun 6, 2024 · 41d8f05 · 41d8f05
1 parent 19c313f
commit 41d8f05
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 18 deletions.
diff --git a/apriltag/src/main/java/edu/wpi/first/apriltag/AprilTagFieldLayout.java b/apriltag/src/main/java/edu/wpi/first/apriltag/AprilTagFieldLayout.java
@@ -281,11 +281,11 @@ public int hashCode() {
   private static class FieldDimensions {
     @SuppressWarnings("MemberName")
     @JsonProperty(value = "length")
-    public double fieldLength;
+    public final double fieldLength;
 
     @SuppressWarnings("MemberName")
     @JsonProperty(value = "width")
-    public double fieldWidth;
+    public final double fieldWidth;
 
     @JsonCreator()
     FieldDimensions(

diff --git a/cscore/src/main/java/edu/wpi/first/cscore/VideoProperty.java b/cscore/src/main/java/edu/wpi/first/cscore/VideoProperty.java
@@ -212,5 +212,5 @@ public String[] getChoices() {
   }
 
   int m_handle;
-  private Kind m_kind;
+  private final Kind m_kind;
 }
diff --git a/styleguide/pmd-ruleset.xml b/styleguide/pmd-ruleset.xml
@@ -56,7 +56,6 @@
     <exclude name="ExcessiveParameterList" />
     <exclude name="ExcessivePublicCount" />
     <exclude name="GodClass" />
-    <exclude name="ImmutableField" />
     <exclude name="LawOfDemeter" />
     <exclude name="LoosePackageCoupling" />
     <exclude name="NPathComplexity" />

diff --git a/...NewCommands/src/test/java/edu/wpi/first/wpilibj2/command/SwerveControllerCommandTest.java b/...NewCommands/src/test/java/edu/wpi/first/wpilibj2/command/SwerveControllerCommandTest.java
@@ -51,7 +51,7 @@ void cleanup() {
         new SwerveModuleState(0, Rotation2d.kZero)
       };
 
-  private SwerveModulePosition[] m_modulePositions =
+  private final SwerveModulePosition[] m_modulePositions =
       new SwerveModulePosition[] {
         new SwerveModulePosition(0, Rotation2d.kZero),
         new SwerveModulePosition(0, Rotation2d.kZero),

diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java
@@ -37,7 +37,7 @@ private static final class HALJoystickButtons {
   }
 
   private static class HALJoystickAxes {
-    public float[] m_axes;
+    public final float[] m_axes;
     public int m_count;
 
     HALJoystickAxes(int count) {
@@ -46,7 +46,7 @@ private static class HALJoystickAxes {
   }
 
   private static class HALJoystickAxesRaw {
-    public int[] m_axes;
+    public final int[] m_axes;
 
     @SuppressWarnings("unused")
     public int m_count;
@@ -57,7 +57,7 @@ private static class HALJoystickAxesRaw {
   }
 
   private static class HALJoystickPOVs {
-    public short[] m_povs;
+    public final short[] m_povs;
     public int m_count;
 
     HALJoystickPOVs(int count) {
@@ -93,14 +93,14 @@ public enum MatchType {
 
   @SuppressWarnings("MemberName")
   private static class MatchDataSender {
-    StringPublisher gameSpecificMessage;
-    StringPublisher eventName;
-    IntegerPublisher matchNumber;
-    IntegerPublisher replayNumber;
-    IntegerPublisher matchType;
-    BooleanPublisher alliance;
-    IntegerPublisher station;
-    IntegerPublisher controlWord;
+    final StringPublisher gameSpecificMessage;
+    final StringPublisher eventName;
+    final IntegerPublisher matchNumber;
+    final IntegerPublisher replayNumber;
+    final IntegerPublisher matchType;
+    final BooleanPublisher alliance;
+    final IntegerPublisher station;
+    final IntegerPublisher controlWord;
     boolean oldIsRedAlliance = true;
     int oldStationNumber = 1;
     String oldEventName = "";

diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/PneumaticHub.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/PneumaticHub.java
@@ -25,7 +25,7 @@ private static class DataStore implements AutoCloseable {
     private int m_refCount;
     private int m_reservedMask;
     private boolean m_compressorReserved;
-    public int[] m_oneShotDurMs = new int[PortsJNI.getNumREVPHChannels()];
+    public final int[] m_oneShotDurMs = new int[PortsJNI.getNumREVPHChannels()];
     private final Object m_reserveLock = new Object();
 
     DataStore(int module) {

diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/SPI.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/SPI.java
@@ -54,7 +54,7 @@ public enum Mode {
     }
   }
 
-  private int m_port;
+  private final int m_port;
 
   /**
    * Constructor.