[cmd] Deprecate Command.schedule()

It's a footgun and syntactic sugar over the CommandScheduler's schedule method. We don't need syntactic sugar for a footgun.
Gold856 · Sep 17, 2024 · 717f82e · 717f82e
1 parent cea8684
commit 717f82e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java
@@ -514,7 +514,12 @@ public WrapperCommand handleInterrupt(Runnable handler) {
         });
   }
 
-  /** Schedules this command. */
+  /**
+   * Schedules this command.
+   *
+   * @deprecated Use CommandScheduler.getInstance().schedule(Command...) instead
+   */
+  @Deprecated(since = "2025", forRemoval = true)
   public void schedule() {
     CommandScheduler.getInstance().schedule(this);
   }

diff --git a/wpilibNewCommands/src/main/native/include/frc2/command/Command.h b/wpilibNewCommands/src/main/native/include/frc2/command/Command.h
@@ -406,7 +406,10 @@ class Command : public wpi::Sendable, public wpi::SendableHelper<Command> {
 
   /**
    * Schedules this command.
+   *
+   * @deprecated Use CommandScheduler::GetInstance().Schedule() instead
    */
+  [[deprecated("Use CommandScheduler::GetInstance().Schedule() instead.")]]
   void Schedule();
 
   /**