Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

v0.18.5

Compare
Choose a tag to compare
@afalaleev afalaleev released this 04 Sep 15:00
· 177 commits to master since this release
88088b7

GOLOS·CORE

The new version SoftFork 0.18.5

Golos·Core announced the SoftFork 0.18.5 version release which eliminated previously existing defects in the system.

Reindexing:
SF 0.18.5 requires reindexing from all previous versions except version SF 0.18.4.

Defects fixed in this release

Defect (Task№) Abstract
943 Problem of creating a list of operations for operation_history plugin
936 The get_ops_in_block method, unlike the get_block method, did not provide information about virtual operations in block
948 Removed the first argument in the method broadcast_transaction_with_callback did not allow this method to be used in third-party libraries

Problem of creating a list of operations for operation_history plugin

Bug description
Some plugins, including operation_history, had difficulty setting options (keys).

For example, executing a command of the form “./golosd --=123” for keys history-blocks, history-start-block failed with the error message:
“Error parsing command line: option --history-blocks is ambiguous and matches different versions of --history-blocks”.

The error occurred when trying to run this command also with some other keys available in program_options.

Solution
The add_option method has been improved. Each of the plugins contains two objects program_options, this is either cli (command line options) or cfg (config file options). To declare a parameter, it has to be added to the cfg object with a required value.

The error cause was an additional declaration of parameters in cli, which caused duplicates in general list of parameters. The solution was based on removing the parameter declaration from the cli object.

The change is made to the following plugins:

  • account_history;
  • debug_node;
  • follow;
  • market_history;
  • operation_history;
  • statsd;
  • witness.

The get_ops_in_block method, unlike the get_block method, did not provide information about virtual operations in block

Bug description:

The get_ops_in_block method did not provide information about virtual operations in a block in the return value.

Solution:

It was decided to generate the return value of the get_ops_in_block method similar to the return value of the get_block method. These two methods become identical in structure in this release. The operation_history plugin has been supplemented with the get_block_with_virtual_ops method.

Removed the first argument in the method broadcast_transaction_with_callback did not allow this method to be used in third-party libraries

Bug description
In the previous version of softfork-0.18.4, the order of arguments in the broadcast_transaction_with_callback method was changed. The argument at the first position was removed as unused. Because this method was used by third-party libraries, the absence of this argument caused problems. Failure was caused by requirement to check node softfork version to find what arguments should be used to call that method.

Solution:
The removed argument has been returned back to the method broadcast_transaction_with_callback at its previous first position. The argument order and functioning of the libraries have been restored in this release. Additionally, one of checks in the method has been fixed too.

Note:
More information about the changes can be found here:
https://wiki.golos.io/golosd/SoftFork/SF-0.18.5-Release_Notice.html